From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wg9yI-0007cr-Ot for qemu-devel@nongnu.org; Fri, 02 May 2014 05:41:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wg9yD-0007lZ-3S for qemu-devel@nongnu.org; Fri, 02 May 2014 05:41:34 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:51305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wg9yC-0007lV-Oi for qemu-devel@nongnu.org; Fri, 02 May 2014 05:41:28 -0400 Received: by mail-wg0-f48.google.com with SMTP id x13so770356wgg.7 for ; Fri, 02 May 2014 02:41:27 -0700 (PDT) Date: Fri, 2 May 2014 11:41:25 +0200 From: Stefan Hajnoczi Message-ID: <20140502094125.GH8005@stefanha-thinkpad.redhat.com> References: <1398751349-20869-1-git-send-email-mjt@msgid.tls.msk.ru> <1398751349-20869-2-git-send-email-mjt@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398751349-20869-2-git-send-email-mjt@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH 1/5] do not call g_thread_init() for glib >= 2.31 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Benoit Canet , qemu-devel@nongnu.org, Christophe Fergeau , Alon Levy , Stefan Hajnoczi , Paolo Bonzini On Tue, Apr 29, 2014 at 10:02:24AM +0400, Michael Tokarev wrote: > glib >= 2.31 always enables thread support and g_thread_supported() > is #defined to 1, there's no need to call g_thread_init() anymore, > and it definitely does not need to report error which never happens. > Keep code for old < 2.31 glibc anyway for now, just #ifdef it > differently. > > Signed-off-by: Michael Tokarev > --- > coroutine-gthread.c | 7 ++----- > util/osdep.c | 21 +++++++++------------ > 2 files changed, 11 insertions(+), 17 deletions(-) Reviewed-by: Stefan Hajnoczi