Re: [Qemu-devel] [PATCH] configure: remove bashism

[Fam Zheng <famz@redhat.com>]

On Fri, 05/02 15:41, Michael Tokarev wrote:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules.  This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some

s/whcih/which

> shells.  Get rid of it, use standard redirection instead.
> 
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c &>/dev/null; then
> +        if which $c >/dev/null 2>&1; then
>              shacmd="$c"
>              break
>          fi
> -- 
> 1.7.10.4
> 

Thanks. With the typo in commit message fixed,

Reviewed-by: Fam Zheng <famz@redhat.com>