From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WhDr0-0005Vp-5D
	for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WhDqv-0003fc-36
	for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WhDqu-0003fP-Sb
	for qemu-devel@nongnu.org; Mon, 05 May 2014 04:02:21 -0400
Date: Mon, 5 May 2014 11:01:10 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140505080110.GA11352@redhat.com>
References: <1398200431-13494-1-git-send-email-hpoussin@reactos.org>
	<53655409.4080903@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <53655409.4080903@reactos.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] i8259: don't abort when trying to use
 level sensitive irqs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Sat, May 03, 2014 at 10:39:37PM +0200, Herv=E9 Poussineau wrote:
> Ping.
>=20
> Le 22/04/2014 23:00, Herv=E9 Poussineau a =E9crit :
> >This is a guest-triggerable error, as seen when using Xenix 2.3.4.
> >Replace hw_error by LOG_UNIMPL, so that guests have at least a chance =
to continue.
> >
> >Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>

Is it just "a chance" or does Xenix actually work well with this
applied?


> >---
> >  hw/intc/i8259.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
> >index c6f248b..a069d04 100644
> >--- a/hw/intc/i8259.c
> >+++ b/hw/intc/i8259.c
> >@@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr =
addr64,
> >              s->init4 =3D val & 1;
> >              s->single_mode =3D val & 2;
> >              if (val & 0x08) {
> >-                hw_error("level sensitive irq not supported");
> >+                qemu_log_mask(LOG_UNIMP,
> >+                              "i8259: level sensitive irq not support=
ed\n");
> >              }
> >          } else if (val & 0x08) {
> >              if (val & 0x04) {
> >