From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhHcr-0008Kf-AB
	for qemu-devel@nongnu.org; Mon, 05 May 2014 08:04:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhHci-0007I8-3J
	for qemu-devel@nongnu.org; Mon, 05 May 2014 08:04:05 -0400
Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:45971)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhHch-0007Hn-TM
	for qemu-devel@nongnu.org; Mon, 05 May 2014 08:03:56 -0400
Received: by mail-wi0-f182.google.com with SMTP id r20so2072664wiv.15
	for <qemu-devel@nongnu.org>; Mon, 05 May 2014 05:03:55 -0700 (PDT)
Date: Mon, 5 May 2014 14:03:52 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140505120352.GC16173@stefanha-thinkpad.redhat.com>
References: <1398956086-20171-1-git-send-email-stefanha@redhat.com>
	<1398956086-20171-20-git-send-email-stefanha@redhat.com>
	<20140504115140.GI1124@T430.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140504115140.GI1124@T430.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH 19/22] dataplane: use the QEMU block layer
 for I/O
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, "Shergill,
	Gurinder" <gurinder.shergill@hp.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Vinod, Chegu" <chegu_vinod@hp.com>

On Sun, May 04, 2014 at 07:51:40PM +0800, Fam Zheng wrote:
> On Thu, 05/01 16:54, Stefan Hajnoczi wrote:
> > +    VirtIOBlockRequest *req = g_slice_new(VirtIOBlockRequest);
> 
> Could be g_slice_new0,
> 
> > +    QEMUIOVector *qiov;
> > +    int nb_sectors;
> > +
> > +    /* Fill in virtio block metadata needed for completion */
> > +    memset(req, 0, sizeof(*req));
> 
> so this memset is not needed.

Thanks, will fix.