From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex
Date: Mon, 5 May 2014 14:11:15 +0200 [thread overview]
Message-ID: <20140505121115.GE16173@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <53637C97.7040103@msgid.tls.msk.ru>
On Fri, May 02, 2014 at 03:08:07PM +0400, Michael Tokarev wrote:
> Stefan Hajnoczi:
>
> > Avoid duplicating ifdefs for the deprecated GStaticMutex API by
> > introducing compat_g_static_mutex_*() in glib-compat.h.
> >
> > GStaticMutex users should use the compat API to avoid dealing with
> > deprecation.
>
> To my taste this is a wrong(ish) approach.
The different approaches to hiding gthread API deprecation have their
pros/cons but mostly a question of taste. If you want to merge your
patch I'm fine with that.
Stefan
next prev parent reply other threads:[~2014-05-05 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 11:08 [Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex Michael Tokarev
2014-05-05 12:11 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-03 13:31 [Qemu-devel] [PATCH 0/3] glib: move compat functions into glib-compat.h Stefan Hajnoczi
2014-02-03 13:31 ` [Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505121115.GE16173@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).