From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLCI-0001x0-Gz for qemu-devel@nongnu.org; Mon, 05 May 2014 11:53:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhLCD-0006DD-II for qemu-devel@nongnu.org; Mon, 05 May 2014 11:52:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhLCD-0006D9-AM for qemu-devel@nongnu.org; Mon, 05 May 2014 11:52:49 -0400 Date: Mon, 5 May 2014 18:51:38 +0300 From: "Michael S. Tsirkin" Message-ID: <20140505155138.GA16355@redhat.com> References: <1399301571-6769-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399301571-6769-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: pbonzini@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, dslutz@verizon.com, afaerber@suse.de On Mon, May 05, 2014 at 10:52:49AM -0400, Gabriel L. Somlo wrote: > On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote: > > From what I understand about the compat bits (which is little) this > > makes a lot of sense. And the version is a proper property now, > > which is great :). > > > > Acked-by: Alexander Graf > > Thanks! Here's a new version with only 8 bits dedicated to the > "implementation version", as specified in the documentation for > the "apic version register". > > Cheers, > Gabriel Acked-by: Michael S. Tsirkin I'll pick this up unless there are objections. > Gabriel L. Somlo (2): > pc: add compat_props placeholder for 2.0 machine type > apic: use emulated lapic version 0x14 on pc machines >= 2.1 > > hw/i386/pc_piix.c | 4 ++++ > hw/i386/pc_q35.c | 4 ++++ > hw/intc/apic.c | 2 +- > hw/intc/apic_common.c | 1 + > include/hw/i386/apic_internal.h | 1 + > include/hw/i386/pc.h | 12 ++++++++++++ > 6 files changed, 23 insertions(+), 1 deletion(-) > > -- > 1.9.0