Re: [Qemu-devel] [PATCH 2/7] monitor: Convert help|? to use command_completion.

Re: [Qemu-devel] [PATCH 2/7] monitor: Convert help|? to use command_completion.

[Luiz Capitulino]

On Sun, 27 Apr 2014 17:00:03 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
>  hmp-commands.hx |  1 +
>  hmp.h           |  1 +
>  monitor.c       | 24 +++++++++++++++++-------
>  3 files changed, 19 insertions(+), 7 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index b3f45d6..ba13997 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -15,6 +15,7 @@ ETEXI
>          .params     = "[cmd]",
>          .help       = "show the help",
>          .mhandler.cmd = do_help_cmd,
> +        .command_completion = help_completion,
>      },
>  
>  STEXI
> diff --git a/hmp.h b/hmp.h
> index 12e21e7..55f78fa 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -98,5 +98,6 @@ void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
>  void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
>  void device_del_completion(ReadLineState *rs, int nb_args, const char *str);
>  void sendkey_completion(ReadLineState *rs, int nb_args, const char *str);
> +void help_completion(ReadLineState *rs, int nb_args, const char *str);
>  
>  #endif
> diff --git a/monitor.c b/monitor.c
> index 7edfcee..acbbaf8 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4407,6 +4407,23 @@ void sendkey_completion(ReadLineState *rs, int nb_args, const char *str)
>      }
>  }
>  
> +void help_completion(ReadLineState *rs, int nb_args, const char *str)
> +{
> +    int i;
> +    size_t len;
> +
> +    if (nb_args != 2) {
> +        return;
> +    }
> +    len = strlen(str);
> +    readline_set_completion_index(rs, len);
> +    for (i = 0; mon_cmds[i].name; i++) {
> +        if (!strncmp(str, mon_cmds[i].name, len)) {
> +            readline_add_completion(rs, mon_cmds[i].name);
> +        }
> +    }
> +}
> +
>  static void monitor_find_completion_by_table(Monitor *mon,
>                                               const mon_cmd_t *cmd_table,
>                                               char **args,
> @@ -4473,13 +4490,6 @@ static void monitor_find_completion_by_table(Monitor *mon,
>              readline_set_completion_index(mon->rs, strlen(str));
>              bdrv_iterate(block_completion_it, &mbs);
>              break;
> -        case 's':
> -        case 'S':
> -            if (!strcmp(cmd->name, "help|?")) {
> -                monitor_find_completion_by_table(mon, cmd_table,
> -                                                 &args[1], nb_args - 1);
> -            }
> -            break;
>          default:
>              break;
>          }

This breaks auto-completion for:

(qemu) help info v

Which would auto-complete "vnc". IIRC, that's one of the reasons we have
monitor_find_completion_by_table().

Re: [Qemu-devel] [PATCH 0/7] Miscellaneous command completion patches

[Luiz Capitulino]

On Sun, 27 Apr 2014 17:00:01 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Compared to the larger series sent before:
> * Patches 01-03 are already in qmp branch.
> * Added patches to convert sendkey, help/? to use new completion callback.
> * Dropped patch 06 (cpu index completion) as deemed not useful enough.
> * netdev_add now uses the same values array as qapi instead of hardcoding them.
> * Left patches 10-17 for a separate series to make review process faster.
> * wrt. to Luiz' question about set_link patch: It prints both backend and
>   frontend values because both are accepted by set_link command.
> 
> Hani Benhabiles (7):
>   monitor: Convert sendkey to use command_completion.
>   monitor: Convert help|? to use command_completion.
>   monitor: Add chardev-remove command completion.
>   monitor: Add chardev-add backend argument completion.
>   monitor: Add set_link arguments completion.
>   monitor: Add netdev_add type argument completion.
>   monitor: Add netdev_del id argument completion.

The first patch looks good. The second one has a problem. For the other
patches it would help me to get Reviewed-bys by the following people:

 o Gerd: patch 03/07 and patch 04/07
 o Stefan: patches 05/07, 06/07 and 07/07

Re: [Qemu-devel] [PATCH 5/7] monitor: Add set_link arguments completion.

[Stefan Hajnoczi]

On Sun, Apr 27, 2014 at 05:00:06PM +0100, Hani Benhabiles wrote:
> Make it possible to query all net clients without specifying an ID when calling
> qemu_find_net_clients_except().
> 
> This also adds the add_completion_option() function which is to be used for
> other commands completions as well.
> 
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
>  hmp-commands.hx |  1 +
>  hmp.h           |  1 +
>  monitor.c       | 34 ++++++++++++++++++++++++++++++++++
>  net/net.c       |  2 +-
>  4 files changed, 37 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH 6/7] monitor: Add netdev_add type argument completion.

[Stefan Hajnoczi]

On Sun, Apr 27, 2014 at 05:00:07PM +0100, Hani Benhabiles wrote:
> Also update the command's documentation.
> 
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
>  hmp-commands.hx |  3 ++-
>  hmp.h           |  1 +
>  monitor.c       | 15 +++++++++++++++
>  3 files changed, 18 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH 7/7] monitor: Add netdev_del id argument completion.

[Stefan Hajnoczi]

On Sun, Apr 27, 2014 at 05:00:08PM +0100, Hani Benhabiles wrote:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
>  hmp-commands.hx |  1 +
>  hmp.h           |  1 +
>  monitor.c       | 26 ++++++++++++++++++++++++++
>  3 files changed, 28 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH 2/7] monitor: Convert help|? to use command_completion.

[Hani Benhabiles]

On Mon, May 05, 2014 at 03:51:37PM -0400, Luiz Capitulino wrote:
> On Sun, 27 Apr 2014 17:00:03 +0100
> Hani Benhabiles <kroosec@gmail.com> wrote:
> 
> > Signed-off-by: Hani Benhabiles <hani@linux.com>
> > ---
> >  hmp-commands.hx |  1 +
> >  hmp.h           |  1 +
> >  monitor.c       | 24 +++++++++++++++++-------
> >  3 files changed, 19 insertions(+), 7 deletions(-)
> > 
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index b3f45d6..ba13997 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -15,6 +15,7 @@ ETEXI
> >          .params     = "[cmd]",
> >          .help       = "show the help",
> >          .mhandler.cmd = do_help_cmd,
> > +        .command_completion = help_completion,
> >      },
> >  
> >  STEXI
> > diff --git a/hmp.h b/hmp.h
> > index 12e21e7..55f78fa 100644
> > --- a/hmp.h
> > +++ b/hmp.h
> > @@ -98,5 +98,6 @@ void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
> >  void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
> >  void device_del_completion(ReadLineState *rs, int nb_args, const char *str);
> >  void sendkey_completion(ReadLineState *rs, int nb_args, const char *str);
> > +void help_completion(ReadLineState *rs, int nb_args, const char *str);
> >  
> >  #endif
> > diff --git a/monitor.c b/monitor.c
> > index 7edfcee..acbbaf8 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -4407,6 +4407,23 @@ void sendkey_completion(ReadLineState *rs, int nb_args, const char *str)
> >      }
> >  }
> >  
> > +void help_completion(ReadLineState *rs, int nb_args, const char *str)
> > +{
> > +    int i;
> > +    size_t len;
> > +
> > +    if (nb_args != 2) {
> > +        return;
> > +    }
> > +    len = strlen(str);
> > +    readline_set_completion_index(rs, len);
> > +    for (i = 0; mon_cmds[i].name; i++) {
> > +        if (!strncmp(str, mon_cmds[i].name, len)) {
> > +            readline_add_completion(rs, mon_cmds[i].name);
> > +        }
> > +    }
> > +}
> > +
> >  static void monitor_find_completion_by_table(Monitor *mon,
> >                                               const mon_cmd_t *cmd_table,
> >                                               char **args,
> > @@ -4473,13 +4490,6 @@ static void monitor_find_completion_by_table(Monitor *mon,
> >              readline_set_completion_index(mon->rs, strlen(str));
> >              bdrv_iterate(block_completion_it, &mbs);
> >              break;
> > -        case 's':
> > -        case 'S':
> > -            if (!strcmp(cmd->name, "help|?")) {
> > -                monitor_find_completion_by_table(mon, cmd_table,
> > -                                                 &args[1], nb_args - 1);
> > -            }
> > -            break;
> >          default:
> >              break;
> >          }
> 
> This breaks auto-completion for:
> 
> (qemu) help info v
> 
> Which would auto-complete "vnc". IIRC, that's one of the reasons we have
> monitor_find_completion_by_table().

Thanks for spotting that.

Quickly thinking about it, a possible way to solve this is to change
command_completion() prototype to be passed the whole args table, and not just a
string and then have those "special cases" (like help+info) handled.

Better drop patch 02/07 and leave the rest as is for now, I believe. I will send
a v2.