From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhOyL-0002lq-VL
	for qemu-devel@nongnu.org; Mon, 05 May 2014 15:54:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhOyF-0005KD-QN
	for qemu-devel@nongnu.org; Mon, 05 May 2014 15:54:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhOy9-0005Jy-K9
	for qemu-devel@nongnu.org; Mon, 05 May 2014 15:54:39 -0400
Date: Mon, 5 May 2014 15:54:30 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140505155430.6035c840@redhat.com>
In-Reply-To: <1398614409-30792-1-git-send-email-kroosec@gmail.com>
References: <1398614409-30792-1-git-send-email-kroosec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] Miscellaneous command completion
	patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, kraxel@redhat.com

On Sun, 27 Apr 2014 17:00:01 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Compared to the larger series sent before:
> * Patches 01-03 are already in qmp branch.
> * Added patches to convert sendkey, help/? to use new completion callback.
> * Dropped patch 06 (cpu index completion) as deemed not useful enough.
> * netdev_add now uses the same values array as qapi instead of hardcoding them.
> * Left patches 10-17 for a separate series to make review process faster.
> * wrt. to Luiz' question about set_link patch: It prints both backend and
>   frontend values because both are accepted by set_link command.
> 
> Hani Benhabiles (7):
>   monitor: Convert sendkey to use command_completion.
>   monitor: Convert help|? to use command_completion.
>   monitor: Add chardev-remove command completion.
>   monitor: Add chardev-add backend argument completion.
>   monitor: Add set_link arguments completion.
>   monitor: Add netdev_add type argument completion.
>   monitor: Add netdev_del id argument completion.

The first patch looks good. The second one has a problem. For the other
patches it would help me to get Reviewed-bys by the following people:

 o Gerd: patch 03/07 and patch 04/07
 o Stefan: patches 05/07, 06/07 and 07/07