* Re: [Qemu-devel] [PATCH v2] qapi: treat all negative return of strtosz_suffix() as error
[not found] <1398664429-10682-1-git-send-email-akong@redhat.com>
@ 2014-05-05 20:10 ` Luiz Capitulino
0 siblings, 0 replies; only message in thread
From: Luiz Capitulino @ 2014-05-05 20:10 UTC (permalink / raw)
To: Amos Kong; +Cc: mst, qemu-devel, mdroth
On Mon, 28 Apr 2014 13:53:49 +0800
Amos Kong <akong@redhat.com> wrote:
> strtosz_suffix() might return negative error, this patch fixes
> the error handling.
>
> This patch also changes to handle error in the if statement
> rather than handle success specially, this will make this use
> of strtosz_suffix consistent with all other uses.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Applied to the qmp branch, thanks.
> ---
> qapi/opts-visitor.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> index 5d830a2..87c1c78 100644
> --- a/qapi/opts-visitor.c
> +++ b/qapi/opts-visitor.c
> @@ -472,13 +472,14 @@ opts_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp)
>
> val = strtosz_suffix(opt->str ? opt->str : "", &endptr,
> STRTOSZ_DEFSUFFIX_B);
> - if (val != -1 && *endptr == '\0') {
> - *obj = val;
> - processed(ov, name);
> + if (val < 0 || *endptr) {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE, opt->name,
> + "a size value representible as a non-negative int64");
> return;
> }
> - error_set(errp, QERR_INVALID_PARAMETER_VALUE, opt->name,
> - "a size value representible as a non-negative int64");
> +
> + *obj = val;
> + processed(ov, name);
> }
>
>
^ permalink raw reply [flat|nested] only message in thread