From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPXc-00074c-A5
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:31:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPXX-0000w8-Ne
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:31:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPXX-0000vr-Gw
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:31:07 -0400
Date: Mon, 5 May 2014 16:31:01 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140505163101.48628872@redhat.com>
In-Reply-To: <20140502135241.31383.48774.stgit@fimbulvetr.bsc.es>
References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es>
	<20140502135241.31383.48774.stgit@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include
 other files from a QAPI schema file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TGx1w61z?= Vilanova <vilanova@ac.upc.edu>
Cc: =?UTF-8?B?QmVub8OudA==?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Fri,  2 May 2014 15:52:41 +0200
Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> wrote:

> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -11,6 +11,8 @@
>  # This work is licensed under the terms of the GNU GPL, version 2.
>  # See the COPYING file in the top-level directory.
> =20
> +import os
> +import re
>  from ordereddict import OrderedDict
>  import os
>  import sys
> @@ -36,9 +38,17 @@ builtin_type_qtypes =3D {
>      'uint64':   'QTYPE_QINT',
>  }

You're importing os twice in this series. I saw this while applying an
unrelated patch on top. I'll drop the import added by this patch, please
reply ACKing or NACKing.