From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPrM-0002eK-7T for qemu-devel@nongnu.org; Mon, 05 May 2014 16:51:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhPrG-00081Y-QQ for qemu-devel@nongnu.org; Mon, 05 May 2014 16:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhPrG-00081L-Im for qemu-devel@nongnu.org; Mon, 05 May 2014 16:51:30 -0400 Date: Mon, 5 May 2014 16:51:04 -0400 From: Luiz Capitulino Message-ID: <20140505165104.0d54b9f5@redhat.com> In-Reply-To: <1398668558-16687-1-git-send-email-akong@redhat.com> References: <1398668558-16687-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: famz@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com On Mon, 28 Apr 2014 15:02:35 +0800 Amos Kong wrote: > Not a serious issue, but it's helpful if we can fix it. > > V2: split change of scripts/qapi-visit.py to a split patch, > eat space by using a special char as Markus suggested > V3: update commitlog, update special string, fix of adding > const replace string by pattern > > Amos Kong (3): > qapi: fix coding style in parameters list > qapi: add const prefix to 'char *' insider c_type() > qapi: Suppress unwanted space between type and identifier Applied to the qmp branch. The last conflicts with another patch I applied to my tree (both are importing re module). I fixed it myself by dropping your import.