From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35513)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPwj-0006d7-Kl
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:57:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPwd-0001Y1-UH
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:57:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9633)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhPwd-0001Xt-NR
	for qemu-devel@nongnu.org; Mon, 05 May 2014 16:57:03 -0400
Date: Mon, 5 May 2014 16:56:59 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140505165659.67290370@redhat.com>
In-Reply-To: <20140505165104.0d54b9f5@redhat.com>
References: <1398668558-16687-1-git-send-email-akong@redhat.com>
	<20140505165104.0d54b9f5@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated
 code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: famz@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com

On Mon, 5 May 2014 16:51:04 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Mon, 28 Apr 2014 15:02:35 +0800
> Amos Kong <akong@redhat.com> wrote:
> 
> > Not a serious issue, but it's helpful if we can fix it.
> > 
> > V2: split change of scripts/qapi-visit.py to a split patch,
> >     eat space by using a special char as Markus suggested
> > V3: update commitlog, update special string, fix of adding
> >     const replace string by pattern
> > 
> > Amos Kong (3):
> >   qapi: fix coding style in parameters list
> >   qapi: add const prefix to 'char *' insider c_type()
> >   qapi: Suppress unwanted space between type and identifier
> 
> Applied to the qmp branch.
> 
> The last conflicts with another patch I applied to my tree (both
> are importing re module). I fixed it myself by dropping your import.

I couldn't understand what I wrote myself :)

The last patch in this series does:

-import sys
+import sys, re

However, module re is already included by another patch in my queue.
So, I dropped those two lines from the last patch in this series.