qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	qemu-devel@nongnu.org, "Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver
Date: Tue, 6 May 2014 10:10:58 +0200	[thread overview]
Message-ID: <20140506081058.GA8923@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5367B9FB.6060606@redhat.com>

On Mon, May 05, 2014 at 06:19:07PM +0200, Max Reitz wrote:
> On 10.04.2014 20:43, Max Reitz wrote:
> >This series adds a passthrough JSON protocol block driver. Its filenames
> >are JSON objects prefixed by "json:". The objects are used as options
> >for opening another block device which will be the child of the JSON
> >device. Regarding this child device, the JSON driver behaves nearly the
> >same as raw_bsd in that it is just a passthrough driver. The only
> >difference is probably that the JSON driver identifies itself as a block
> >filter, in contrast to raw_bsd.
> >
> >The purpose of this driver is that it may sometimes be desirable to
> >specify options for a block device where only a filename can be given,
> >e.g., for backing files. Using this should obviously be the exception,
> >but it is nice to have if actually needed.
> 
> Ping – I do understand that Kevin has reservations against this
> series, but as long as he doesn't explicitly ask me to reimplement
> this in bdrv_open() without an own block driver (which I'd more or
> less gladly do), I do not see issues why this series should not be
> merged.

I haven't reviewed it further because it seems like a kludge (that we
have to keep supporting once it's merged).  Was hoping you and Kevin
will come up with a long-term fix instead.

Kevin: Any new ideas on this patch series?

Stefan

  reply	other threads:[~2014-05-06  8:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 18:43 [Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 01/12] qdict: Add qdict_join() Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 02/12] check-qdict: Add test for qdict_join() Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 03/12] block: Add "has_single_child" field for drivers Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 04/12] block/json: Add JSON protocol driver Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 05/12] block/json: Add functions for cache control Max Reitz
2014-04-10 18:57   ` Benoît Canet
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 06/12] block/json: Add functions for writing zeroes etc Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 07/12] block/json: Add bdrv_co_get_block_status() Max Reitz
2014-04-10 18:58   ` Benoît Canet
2014-04-10 19:00     ` Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 08/12] block/json: Add ioctl etc Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 09/12] block/json: Add bdrv_get_specific_info() Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 10/12] block/raw_bsd: " Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 11/12] block/qapi: Ignore filters on top for format name Max Reitz
2014-04-10 18:43 ` [Qemu-devel] [PATCH v3 12/12] iotests: Add test for the JSON protocol Max Reitz
2014-05-05 16:19 ` [Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver Max Reitz
2014-05-06  8:10   ` Stefan Hajnoczi [this message]
2014-05-06 17:51     ` Max Reitz
2014-05-07  7:29       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140506081058.GA8923@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).