From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhezZ-0002Ip-C1
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:01:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhezS-0004Us-Pp
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:01:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WhezS-0004Uf-8G
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:00:58 -0400
Date: Tue, 6 May 2014 09:00:11 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140506090011.5f8f8a86@redhat.com>
In-Reply-To: <536800FD.3000708@redhat.com>
References: <1398668558-16687-1-git-send-email-akong@redhat.com>
	<20140505165104.0d54b9f5@redhat.com> <536800FD.3000708@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated
 code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: famz@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, Amos Kong <akong@redhat.com>

On Mon, 05 May 2014 23:22:05 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 05/05/2014 22:51, Luiz Capitulino ha scritto:
> > On Mon, 28 Apr 2014 15:02:35 +0800
> > Amos Kong <akong@redhat.com> wrote:
> >
> >> Not a serious issue, but it's helpful if we can fix it.
> >>
> >> V2: split change of scripts/qapi-visit.py to a split patch,
> >>     eat space by using a special char as Markus suggested
> >> V3: update commitlog, update special string, fix of adding
> >>     const replace string by pattern
> >>
> >> Amos Kong (3):
> >>   qapi: fix coding style in parameters list
> >>   qapi: add const prefix to 'char *' insider c_type()
> >>   qapi: Suppress unwanted space between type and identifier
> >
> > Applied to the qmp branch.
> >
> > The last conflicts with another patch I applied to my tree (both
> > are importing re module). I fixed it myself by dropping your import.
> >
> 
> Did you address my comment at
> http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg04445.html
> while applying, too?

No, I thought you were OK with the current version. If you're not then
Amos will have to respin.

Amos, if you do respin please rebase on top of the qmp queue:

  git://repo.or.cz/qemu/qmp-unstable.git queue/qmp