From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhdaH-0007hf-Rs for qemu-devel@nongnu.org; Tue, 06 May 2014 07:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhdaD-0006WG-6v for qemu-devel@nongnu.org; Tue, 06 May 2014 07:30:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhdaC-0006Vo-Vx for qemu-devel@nongnu.org; Tue, 06 May 2014 07:30:49 -0400 Date: Tue, 6 May 2014 13:30:24 +0200 From: Stefan Hajnoczi Message-ID: <20140506113024.GC15810@stefanha-thinkpad.redhat.com> References: <1399308814-30195-1-git-send-email-ncmike@ncultra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399308814-30195-1-git-send-email-ncmike@ncultra.org> Subject: Re: [Qemu-devel] [PATCH] [v2 PATCH] qemu-img: sort block formats in help message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day Cc: kwolf@redhat.com, Fam Zheng , qemu-devel@nongnu.org On Mon, May 05, 2014 at 12:53:34PM -0400, Mike Day wrote: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints the formats in sorted order, making it > easier to read and to find a specific format in the list. > > v2: Incorporated feedback from Stefan Hajnoczi > > Signed-off-by: Mike Day > --- > qemu-img.c | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) Thanks, applied to my block tree with Fam's suggestions squashed in: https://github.com/stefanha/qemu/commits/block Stefan