From: Kevin Wolf <kwolf@redhat.com>
To: Matthew Booth <mbooth@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 28/31] curl: Remove unnecessary explicit calls to internal event handler
Date: Tue, 6 May 2014 15:12:54 +0200 [thread overview]
Message-ID: <20140506131254.GE3941@noname.str.redhat.com> (raw)
In-Reply-To: <5368D888.4010603@redhat.com>
Am 06.05.2014 um 14:41 hat Matthew Booth geschrieben:
> On 06/05/14 10:56, Kevin Wolf wrote:
> > Am 06.05.2014 um 11:44 hat Laurent Desnogues geschrieben:
> >> curl_multi_socket_action isn't available on the CURL lib used
> >> by CentOS 5.6. The obvious workaround is to disable CURL
> >> when calling configure.
> >
> > Matthew, can you please check whether this call can be avoided, or
> > otherwise change configure to check the presence of the function?
>
> I should be able to sort this if I can work out how to add a configure
> test. When do you need it by? If I'm too slow it's safe to revert this
> change. It's just a cleanup to remove use of a deprecated api.
We have plenty of time until 2.1, so I don't think that's a problem.
Anyway, if you need to do the configure change, just search for "curl" in
configure. We already probe for some functions, you can just add another
call in the program for the test compile.
Kevin
prev parent reply other threads:[~2014-05-06 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398882243-14783-1-git-send-email-kwolf@redhat.com>
2014-05-02 10:34 ` [Qemu-devel] [PULL 00/31] Block patches Peter Maydell
[not found] ` <1398882243-14783-17-git-send-email-kwolf@redhat.com>
2014-05-04 10:13 ` [Qemu-devel] [PULL 16/31] block: Fix open_flags in bdrv_reopen() Jan Kiszka
[not found] ` <1398882243-14783-29-git-send-email-kwolf@redhat.com>
2014-05-06 9:44 ` [Qemu-devel] [PULL 28/31] curl: Remove unnecessary explicit calls to internal event handler Laurent Desnogues
2014-05-06 9:56 ` Kevin Wolf
2014-05-06 12:41 ` Matthew Booth
2014-05-06 13:12 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506131254.GE3941@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=laurent.desnogues@gmail.com \
--cc=mbooth@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).