From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfCl-0003rk-Pq for qemu-devel@nongnu.org; Tue, 06 May 2014 09:14:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhfCg-0000yb-3Z for qemu-devel@nongnu.org; Tue, 06 May 2014 09:14:43 -0400 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:57335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfCf-0000yR-Sq for qemu-devel@nongnu.org; Tue, 06 May 2014 09:14:38 -0400 Received: by mail-we0-f180.google.com with SMTP id t61so3605827wes.25 for ; Tue, 06 May 2014 06:14:36 -0700 (PDT) Date: Tue, 6 May 2014 15:14:31 +0200 From: Stefan Hajnoczi Message-ID: <20140506131431.GO15810@stefanha-thinkpad.redhat.com> References: <1398762656-26079-1-git-send-email-cyliu@suse.com> <1398762656-26079-3-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398762656-26079-3-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH V26 02/32] QemuOpts: add def_value_str to QemuOptDesc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Apr 29, 2014 at 05:10:26PM +0800, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. > > Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise, > if desc->def_value_str is set, return desc->def_value_str; otherwise, return > input defval. > > Improve qemu_opts_print: if option is set, print opt->str; otherwise, if > desc->def_value_str is set, also print it. It will replace > print_option_parameters. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > Changes to V25: > * split v25 patch into two: this one and next one. > * this patch is the same as v22 which is reviewed-by Eric. > > include/qemu/option.h | 3 ++- > util/qemu-option.c | 56 ++++++++++++++++++++++++++++++++++++++++++--------- > 2 files changed, 49 insertions(+), 10 deletions(-) Modulo Eric's comment: Reviewed-by: Stefan Hajnoczi