From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfCw-000461-Tp for qemu-devel@nongnu.org; Tue, 06 May 2014 09:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhfCr-00011w-7v for qemu-devel@nongnu.org; Tue, 06 May 2014 09:14:54 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:64280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfCr-00011l-0W for qemu-devel@nongnu.org; Tue, 06 May 2014 09:14:49 -0400 Received: by mail-wi0-f178.google.com with SMTP id hm4so891242wib.11 for ; Tue, 06 May 2014 06:14:48 -0700 (PDT) Date: Tue, 6 May 2014 15:14:45 +0200 From: Stefan Hajnoczi Message-ID: <20140506131445.GP15810@stefanha-thinkpad.redhat.com> References: <1398762656-26079-1-git-send-email-cyliu@suse.com> <1398762656-26079-4-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398762656-26079-4-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH V26 03/32] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Apr 29, 2014 at 05:10:27PM +0800, Chunyan Liu wrote: > Currently this function is not used anywhere. In later patches, it will > replace print_option_parameters. To avoid print info changes, change > qemu_opts_print from fprintf stderr to printf to keep consistent with > print_option_parameters, remove last printf and print size/number with > opt->value.uint instead of opt->str. > > Signed-off-by: Chunyan Liu > --- > util/qemu-option.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi