From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhfKQ-0007dC-2V
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:22:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhfKK-00042y-DH
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:22:38 -0400
Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:51369)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WhfKK-00042g-6j
	for qemu-devel@nongnu.org; Tue, 06 May 2014 09:22:32 -0400
Received: by mail-wi0-f173.google.com with SMTP id bs8so7264093wib.0
	for <qemu-devel@nongnu.org>; Tue, 06 May 2014 06:22:31 -0700 (PDT)
Date: Tue, 6 May 2014 15:22:28 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140506132228.GT15810@stefanha-thinkpad.redhat.com>
References: <1398762656-26079-1-git-send-email-cyliu@suse.com>
	<1398762656-26079-21-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1398762656-26079-21-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [PATCH V26 20/32] qed.c: replace
 QEMUOptionParameter with QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Apr 29, 2014 at 05:10:44PM +0800, Chunyan Liu wrote:
> One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead
> of 64 * 1024; because:
> according to existing create_options, "cluster size" has default value =
> QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be
> stringized and set to .def_value_str. That is,
>   .def_value_str = stringify(QED_DEFAULT_CLUSTER_SIZE),
> so the QED_DEFAULT_CLUSTER_SIZE could not be a expression.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
>  block/qed.c | 114 ++++++++++++++++++++++++++++++++----------------------------
>  block/qed.h |   3 +-
>  2 files changed, 61 insertions(+), 56 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>