From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfO4-0003aQ-H6 for qemu-devel@nongnu.org; Tue, 06 May 2014 09:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhfNy-0005Ur-VH for qemu-devel@nongnu.org; Tue, 06 May 2014 09:26:24 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:64009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhfNy-0005UU-OP for qemu-devel@nongnu.org; Tue, 06 May 2014 09:26:18 -0400 Received: by mail-wi0-f174.google.com with SMTP id r20so3965175wiv.1 for ; Tue, 06 May 2014 06:26:17 -0700 (PDT) Date: Tue, 6 May 2014 15:26:15 +0200 From: Stefan Hajnoczi Message-ID: <20140506132615.GV15810@stefanha-thinkpad.redhat.com> References: <1398762656-26079-1-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398762656-26079-1-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH V26 00/32] replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v25: > * split v25 2/31 (add def_value_str to QemuOptDesc) into two patches: > 1st patch adds def_value_str, 2nd patch repurpose qemu_opts_print. > * update 4/32 qapi command line description. > * update 12/32 (change block layer to support both) according to > Eric's comments. > * small update to gluster.c > * rebase to latest code > > All patches are also available from: > https://github.com/chunyanliu/qemu/commits/QemuOpts I looked through the comments from Leandro and Eric. A respin is necessary to address the test failures that Leandro found. Please also address the comments Eric made. We're almost there now!