From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WhfzB-00075r-Vs
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:04:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Whfz6-0002d0-9j
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:04:45 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:45422 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Whfz6-0002c9-3c
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:04:40 -0400
Date: Tue, 6 May 2014 16:05:08 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140506140508.GA18081@irqsave.net>
References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es>
	<20140506130740.GA17717@irqsave.net>
	<20140506092725.4c195cbd@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140506092725.4c195cbd@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI
 schema files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, =?iso-8859-1?Q?Llu=EDs?= Vilanova <vilanova@ac.upc.edu>

The Tuesday 06 May 2014 =E0 09:27:25 (-0400), Luiz Capitulino wrote :
> On Tue, 6 May 2014 15:07:40 +0200
> Beno=EEt Canet <benoit.canet@irqsave.net> wrote:
>=20
> > I am trying to use this series to modularise the block API.
> >=20
> > Here are my finding.
> >=20
> > I tried to make a qmp/block.json including VM state related API.
> > block.json include a qmp/block-core.json containing only true block s=
tuff.
> >=20
> > When generating and compiling block-core.json to link it with qemu-nb=
d
> > I saw that some of the block stuff needed ErrorClass so I went the ro=
ute
> > of creating a qmp/common.json containing ErrorClass.
> >=20
> > common.json being included in block-core.json and in qapi-schema.json=
 it
> > quickly lead some code being generated in double and the compilation =
to choke.
> >=20
> > What do you think would be the best solution to fix this ?
> > (Fix the generator ? Make include ignore second inclusion of the same=
 file ?)
>=20
> Make qapi-schema.json a sort of master file and include everything?

My problem is that I need something smaller than qapi-schema.json to link=
 against
qemu-nbd.

>=20
> Eventually, we might want to have if/defs and whatnot. But having a mas=
ter
> file seems a reasonable first step to me. I actually thought this was t=
he
> intention. Unless I got it wrong, of course.
>=20