Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

[Kevin Wolf <kwolf@redhat.com>]

Am 06.05.2014 um 23:03 hat Max Reitz geschrieben:
> On 06.05.2014 13:10, Jan Kiszka wrote:
> >On 2014-05-06 12:19, Kevin Wolf wrote:
> >>The immediately visible effect of this patch is that it fixes committing
> >>a temporary snapshot to its backing file. Previously, it would fail with
> >>a "permission denied" error because bdrv_inherited_flags() forced the
> >>backing file to be read-only, ignoring the r/w reopen of bdrv_commit().
> >>
> >>The bigger problem this releaved is that the original open flags must
> >>actually only be applied to the temporary snapshot, and the original
> >>image file must be treated as a backing file of the temporary snapshot
> >>and get the right flags for that.
> >>
> >>Reported-by: Jan Kiszka <jan.kiszka@web.de>
> >>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >>---
> >>  block.c                    | 34 +++++++++++++++++++---------------
> >>  include/block/block.h      |  2 +-
> >>  tests/qemu-iotests/051     |  4 ++++
> >>  tests/qemu-iotests/051.out | 10 ++++++++++
> >>  4 files changed, 34 insertions(+), 16 deletions(-)

> >Works fine here!
> >
> >(For unknown reason, applying the iotest hunk didn't work for me, though.)
> 
> The lines are too long and therefore split in this mail, they need
> to be joined manually before applying the patch.

Perhaps the monitor should be changed to avoid printing so many useless
control characters, then we'd hit the limit less often...

Stefan, didn't you plan to do something like this? Or was it unrelated?

Kevin