From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhxmK-0006Ps-7G for qemu-devel@nongnu.org; Wed, 07 May 2014 05:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhxmE-0001aU-2D for qemu-devel@nongnu.org; Wed, 07 May 2014 05:04:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhxmD-0001aJ-QL for qemu-devel@nongnu.org; Wed, 07 May 2014 05:04:34 -0400 Date: Wed, 7 May 2014 12:03:24 +0300 From: "Michael S. Tsirkin" Message-ID: <20140507090324.GA18283@redhat.com> References: <1399389445-1607-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399389445-1607-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v6 0/2] apic: bump emulated lapic version to 0x14 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: pbonzini@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, afaerber@suse.de On Tue, May 06, 2014 at 11:17:23AM -0400, Gabriel L. Somlo wrote: > This patch set changes the software-emulated local apic version > to 0x14 starting with pc machine types 2.1 and newer. This should > be particularly helpful when running OS X guests with TCG, since > XNU appears to have a hardcoded requirement that lapic version >= 0x14. > > Changelog: > > v6: - rebased to apply cleanly (no fuzz) against latest qemu git > - opportunity to practice dealing with Acked-by and Reviewed-by :) > > v5: convert lapic version to uint8_t (only 8 bits dedicated to > "implementation version" in the apic version register, according to > the Intel spec). > > v4: - split into a two-patch series with cover letter > - 1/2: - introduces empty 2.0 compat_props > - depends on 3458b2b075f92f163ccb9a1f24733eb5705947f0 to add > 2.1 machine type and move aliases (now already upstream, but > not at the time v4 went out :) > - 2/2: - adds lapic version as a machine property defaulting to 0x14 > - set to 0x11 in compat_props for machines 2.0 and older > > v3 and older: single patch, lapic version is global, no cover letter > > Thanks again, > Gabriel Applied, thanks for your patience. > PS. Funny, now that I'm getting close to having figured out the qemu > contributor netiquette, I'm just about done submitting all the changes > I set out to contribute... :) > > Gabriel L. Somlo (2): > pc: add compat_props placeholder for 2.0 machine type > pic: use emulated lapic version 0x14 on pc machines >= 2.1 > > hw/i386/pc_piix.c | 4 ++++ > hw/i386/pc_q35.c | 4 ++++ > hw/intc/apic.c | 2 +- > hw/intc/apic_common.c | 1 + > include/hw/i386/apic_internal.h | 1 + > include/hw/i386/pc.h | 12 ++++++++++++ > 6 files changed, 23 insertions(+), 1 deletion(-) > > -- > 1.9.0