From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51962)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi2wA-000667-5b
	for qemu-devel@nongnu.org; Wed, 07 May 2014 10:35:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi2vx-00052u-Vl
	for qemu-devel@nongnu.org; Wed, 07 May 2014 10:35:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi2vx-00052i-PD
	for qemu-devel@nongnu.org; Wed, 07 May 2014 10:34:57 -0400
Date: Wed, 7 May 2014 10:08:02 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140507100802.69268d84@redhat.com>
In-Reply-To: <87fvkmi0ip.fsf@blackfin.pond.sub.org>
References: <1399030002-27222-1-git-send-email-armbru@redhat.com>
	<1399030002-27222-15-git-send-email-armbru@redhat.com>
	<536390CD.8070106@redhat.com>
	<87fvkmi0ip.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to
 suppress additional errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Wed, 07 May 2014 08:08:30 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Eric Blake <eblake@redhat.com> writes:
> 
> > On 05/02/2014 05:26 AM, Markus Armbruster wrote:
> >> Using error_is_set(errp) that way can sweep programming errors under
> >> the carpet when we get called incorrectly with an error set.
> >> 
> >> encrypted_bdrv_it() does it, because there's no way to make
> >> bdrv_iterate() break its loop.  Actually safe, because qmp_cont()
> >> clears the error before the loop.  Clean it up anyway: replace
> >> bdrv_iterate() by bdrv_next(), break the loop on error.
> >> 
> >> Replace both occurences, for consistency.
> >
> > s/occurences/occurrences/
> >
> >> 
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> Reviewed-by: Eric Blake <eblake@redhat.com>
> >
> > Fixing up the commit message typo is trivial and doesn't alter the
> > positive review.
> 
> Luiz, could you fix it up on commit, when you add Eric's R-by?

Fixed. But I didn't have to add his R-bys, you did it already.