From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: agraf@suse.de, stefanb@linux.vnet.ibm.com, quintela@redhat.com,
mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
aliguori@amazon.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH v2 05/16] Header/constant/types fixes for visitors
Date: Wed, 7 May 2014 11:33:35 +0100 [thread overview]
Message-ID: <20140507103335.GD2644@work-vm> (raw)
In-Reply-To: <20140507094706.GB10830@redhat.com>
* Michael S. Tsirkin (mst@redhat.com) wrote:
> On Wed, Apr 23, 2014 at 05:37:38PM +0100, Dr. David Alan Gilbert (git) wrote:
<snip>
> > +typedef struct {
> > + uint64_t addr;
> > + uint16_t flags;
> > + char idstr[256];
> > + char ch; /* Used for filled pages (normally 0 fill) */
> > + size_t len; /* Uses include xbzrle's data len */
> > +} ramsecentry_header;
> > +
>
>
> RamSecEntryHeader?
Fixed, thanks.
> and maybe we should make this 256 a named constant too.
It's 256 because the old format uses a byte as a length; I've commented
it.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-05-07 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398271069-22057-1-git-send-email-dgilbert@redhat.com>
[not found] ` <1398271069-22057-6-git-send-email-dgilbert@redhat.com>
2014-05-07 9:47 ` [Qemu-devel] [RFC PATCH v2 05/16] Header/constant/types fixes for visitors Michael S. Tsirkin
2014-05-07 10:33 ` Dr. David Alan Gilbert [this message]
[not found] ` <1398271069-22057-2-git-send-email-dgilbert@redhat.com>
2014-05-07 9:50 ` [Qemu-devel] [RFC PATCH v2 01/16] Visitor: Add methods for migration format use Michael S. Tsirkin
2014-05-07 10:23 ` Dr. David Alan Gilbert
2014-05-07 10:32 ` Michael S. Tsirkin
[not found] ` <5357EF56.4010703@redhat.com>
[not found] ` <20140423171622.GG2516@work-vm>
[not found] ` <87sip3dvsj.fsf@blackfin.pond.sub.org>
[not found] ` <20140424082059.GB2459@work-vm>
[not found] ` <20140424082923.GA31845@redhat.com>
[not found] ` <87wqeduc0d.fsf@blackfin.pond.sub.org>
2014-05-06 18:58 ` [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format Dr. David Alan Gilbert
2014-05-06 20:26 ` Michael S. Tsirkin
2014-05-07 5:49 ` Markus Armbruster
2014-05-07 9:22 ` Dr. David Alan Gilbert
[not found] ` <5357FCA9.8040801@redhat.com>
[not found] ` <20140423175410.GA28308@redhat.com>
[not found] ` <53580D27.2080507@redhat.com>
2014-05-07 9:57 ` Michael S. Tsirkin
[not found] ` <1398271069-22057-16-git-send-email-dgilbert@redhat.com>
2014-05-07 10:02 ` [Qemu-devel] [RFC PATCH v2 15/16] Wire in BER visitors Michael S. Tsirkin
2014-05-07 10:08 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507103335.GD2644@work-vm \
--to=dgilbert@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).