From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzAc-0003bZ-4F for qemu-devel@nongnu.org; Wed, 07 May 2014 06:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhzAW-0007t5-0M for qemu-devel@nongnu.org; Wed, 07 May 2014 06:33:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhzAV-0007sz-PX for qemu-devel@nongnu.org; Wed, 07 May 2014 06:33:43 -0400 Date: Wed, 7 May 2014 11:33:35 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140507103335.GD2644@work-vm> References: <1398271069-22057-1-git-send-email-dgilbert@redhat.com> <1398271069-22057-6-git-send-email-dgilbert@redhat.com> <20140507094706.GB10830@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140507094706.GB10830@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 05/16] Header/constant/types fixes for visitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: agraf@suse.de, stefanb@linux.vnet.ibm.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@amazon.com, afaerber@suse.de * Michael S. Tsirkin (mst@redhat.com) wrote: > On Wed, Apr 23, 2014 at 05:37:38PM +0100, Dr. David Alan Gilbert (git) wrote: > > +typedef struct { > > + uint64_t addr; > > + uint16_t flags; > > + char idstr[256]; > > + char ch; /* Used for filled pages (normally 0 fill) */ > > + size_t len; /* Uses include xbzrle's data len */ > > +} ramsecentry_header; > > + > > > RamSecEntryHeader? Fixed, thanks. > and maybe we should make this 256 a named constant too. It's 256 because the old format uses a byte as a length; I've commented it. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK