From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi2yL-0008J5-Ik
	for qemu-devel@nongnu.org; Wed, 07 May 2014 10:37:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi2yD-0005vf-Rf
	for qemu-devel@nongnu.org; Wed, 07 May 2014 10:37:25 -0400
Date: Wed, 7 May 2014 10:37:15 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140507103715.3708b209@redhat.com>
In-Reply-To: <1399390743-21802-1-git-send-email-eblake@redhat.com>
References: <1399390743-21802-1-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Tue,  6 May 2014 09:39:03 -0600
Eric Blake <eblake@redhat.com> wrote:

> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
> 
> * qmp-commands.hx: Use correct JSON quotes.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
> 
>  -> { "execute": "transaction",
>       "arguments": { "actions": [
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
>                                           "snapshot-file": "/some/place/my-image",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
> +         { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "snapshot-node-name": "node3432",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> +         { "type": "blockdev-snapshot-internal-sync", "data" : {
>                                           "device": "ide-hd2",
>                                           "name": "snapshot0" } } ] } }
>  <- { "return": {} }