From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi5Qz-0006C5-Um
	for qemu-devel@nongnu.org; Wed, 07 May 2014 13:15:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi5Qu-00052Z-Pz
	for qemu-devel@nongnu.org; Wed, 07 May 2014 13:15:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55069)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Wi5Qu-00050K-JO
	for qemu-devel@nongnu.org; Wed, 07 May 2014 13:15:04 -0400
Date: Wed, 7 May 2014 13:14:57 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140507131457.1e4b8740@redhat.com>
In-Reply-To: <871tw5h5zn.fsf@fimbulvetr.bsc.es>
References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es>
	<20140505142126.131eb791@redhat.com>
	<20140507123649.148e66c6@redhat.com>
	<871tw5h5zn.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI
	schema files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TGx1w61z?= Vilanova <vilanova@ac.upc.edu>
Cc: =?UTF-8?B?QmVub8OudA==?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Wed, 07 May 2014 19:07:56 +0200
Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> wrote:

> Luiz Capitulino writes:
>=20
> > On Mon, 5 May 2014 14:21:26 -0400
> > Luiz Capitulino <lcapitulino@redhat.com> wrote:
>=20
> >> On Fri,  2 May 2014 15:52:19 +0200
> >> Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> wrote:
> >>=20
> >> > Adds an include primitive to the syntax of QAPI schema files, allowi=
ng these to
> >> > be modularized into multiple per-topic files in the future.
> >> >=20
> >> > Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> >> > Reviewed-by: Eric Blake <eblake@redhat.com>
> >> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> >>=20
> >> Applied to the qmp branch, thanks.
>=20
> > make check fails for me:
>=20
> >   TEST  tests/qapi-schema/include-before-err.out
> > Files /home/lcapitulino/work/src/upstream/qmp-unstable/tests/qapi-schem=
a/include-before-err.err and - differ
> > make: *** [check-tests/qapi-schema/include-before-err.json] Error 1
>=20
> Sorry, it's my fault. I though I did rerun the tests. The change is:
>=20
>   sed -i -e 's/after/before' tests/qapi-schema/include-before-err.err
>=20
> Should I resend the series?

It would be nice if you can resend only the affected patch.