From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi5Z4-0002rc-UM for qemu-devel@nongnu.org; Wed, 07 May 2014 13:23:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wi5Z0-0000Of-5J for qemu-devel@nongnu.org; Wed, 07 May 2014 13:23:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi5Yz-0000OV-S9 for qemu-devel@nongnu.org; Wed, 07 May 2014 13:23:26 -0400 Date: Wed, 7 May 2014 13:23:20 -0400 From: Luiz Capitulino Message-ID: <20140507132320.40302dab@redhat.com> In-Reply-To: <87ha51fqup.fsf@fimbulvetr.bsc.es> References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es> <20140505142126.131eb791@redhat.com> <20140507123649.148e66c6@redhat.com> <871tw5h5zn.fsf@fimbulvetr.bsc.es> <20140507131457.1e4b8740@redhat.com> <87ha51fqup.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61z?= Vilanova Cc: =?UTF-8?B?QmVub8OudA==?= Canet , qemu-devel@nongnu.org, Markus Armbruster On Wed, 07 May 2014 19:20:14 +0200 Llu=C3=ADs Vilanova wrote: > Luiz Capitulino writes: >=20 > > On Wed, 07 May 2014 19:07:56 +0200 > > Llu=C3=ADs Vilanova wrote: >=20 > >> Luiz Capitulino writes: > >>=20 > >> > On Mon, 5 May 2014 14:21:26 -0400 > >> > Luiz Capitulino wrote: > >>=20 > >> >> On Fri, 2 May 2014 15:52:19 +0200 > >> >> Llu=C3=ADs Vilanova wrote: > >> >>=20 > >> >> > Adds an include primitive to the syntax of QAPI schema files, all= owing these to > >> >> > be modularized into multiple per-topic files in the future. > >> >> >=20 > >> >> > Signed-off-by: Llu=C3=ADs Vilanova > >> >> > Reviewed-by: Eric Blake > >> >> > Reviewed-by: Markus Armbruster > >> >>=20 > >> >> Applied to the qmp branch, thanks. > >>=20 > >> > make check fails for me: > >>=20 > >> > TEST tests/qapi-schema/include-before-err.out > >> > Files /home/lcapitulino/work/src/upstream/qmp-unstable/tests/qapi-sc= hema/include-before-err.err and - differ > >> > make: *** [check-tests/qapi-schema/include-before-err.json] Error 1 > >>=20 > >> Sorry, it's my fault. I though I did rerun the tests. The change is: > >>=20 > >> sed -i -e 's/after/before' tests/qapi-schema/include-before-err.err > >>=20 > >> Should I resend the series? >=20 > > It would be nice if you can resend only the affected patch. >=20 > You mean resend a fixed version of the original patch, or a patch on top = of the > series? A fixed version of the original patch. You can do it by replying to the original patch.