qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, Wanlong Gao <gaowanlong@cn.fujitsu.com>,
	Andre Przywara <andre.przywara@amd.com>
Subject: Re: [Qemu-devel] [PATCH v3.1 24/31] configure: add Linux libnuma detection
Date: Wed, 7 May 2014 17:57:13 +0300	[thread overview]
Message-ID: <20140507145713.GB16437@redhat.com> (raw)
In-Reply-To: <c88cdd884506be541c4b7dd7e2bb3bbacd38ad95.1399365798.git.hutao@cn.fujitsu.com>

On Tue, May 06, 2014 at 05:27:45PM +0800, Hu Tao wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> Add detection of libnuma (mostly contained in the numactl package)
> to the configure script. Can be enabled or disabled on the command
> line, default is use if available.
> 
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  configure | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/configure b/configure
> index 870c939..c3df5e6 100755
> --- a/configure
> +++ b/configure
> @@ -324,6 +324,7 @@ tpm="no"
>  libssh2=""
>  vhdx=""
>  quorum="no"
> +numa=""
>  
>  # parse CC options first
>  for opt do
> @@ -1087,6 +1088,10 @@ for opt do
>    ;;
>    --enable-quorum) quorum="yes"
>    ;;
> +  --disable-numa) numa="no"
> +  ;;
> +  --enable-numa) numa="yes"
> +  ;;
>    *)
>        echo "ERROR: unknown option $opt"
>        echo "Try '$0 --help' for more information"
> @@ -1354,6 +1359,8 @@ Advanced options (experts only):
>    --enable-vhdx            enable support for the Microsoft VHDX image format
>    --disable-quorum         disable quorum block filter support
>    --enable-quorum          enable quorum block filter support
> +  --disable-numa           disable libnuma support
> +  --enable-numa            enable libnuma support
>  
>  NOTE: The object files are built at the place where configure is launched
>  EOF
> @@ -3113,6 +3120,27 @@ if compile_prog "" "" ; then
>  fi
>  
>  ##########################################
> +# libnuma probe
> +
> +if test "$numa" != "no" ; then
> +  numa=no
> +  cat > $TMPC << EOF
> +#include <numa.h>
> +int main(void) { return numa_available(); }
> +EOF
> +
> +  if compile_prog "" "-lnuma" ; then
> +    numa=yes
> +    libs_softmmu="-lnuma $libs_softmmu"
> +  else
> +    if test "$numa" = "yes" ; then
> +      feature_not_found "linux NUMA (install numactl?)"

Which distro?
At least for Fedora I think one needs numactl-devel?

> +    fi
> +    numa=no
> +  fi
> +fi
> +
> +##########################################
>  # signalfd probe
>  signalfd="no"
>  cat > $TMPC << EOF
> @@ -4186,6 +4214,7 @@ echo "vhdx              $vhdx"
>  echo "Quorum            $quorum"
>  echo "lzo support       $lzo"
>  echo "snappy support    $snappy"
> +echo "NUMA host support $numa"
>  
>  if test "$sdl_too_old" = "yes"; then
>  echo "-> Your SDL version is too old - please upgrade to have SDL support"
> @@ -5153,6 +5182,10 @@ if [ "$dtc_internal" = "yes" ]; then
>    echo "config-host.h: subdir-dtc" >> $config_host_mak
>  fi
>  
> +if test "$numa" = "yes"; then
> +  echo "CONFIG_NUMA=y" >> $config_host_mak
> +fi
> +
>  # build tree in object directory in case the source is not in the current directory
>  DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests"
>  DIRS="$DIRS fsdev"
> -- 
> 1.8.5.2.229.g4448466
> 

  reply	other threads:[~2014-05-07 14:58 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  9:27 [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 01/31] NUMA: move numa related code to new file numa.c Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 02/31] NUMA: check if the total numa memory size is equal to ram_size Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 03/31] NUMA: Add numa_info structure to contain numa nodes info Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 04/31] NUMA: convert -numa option to use OptsVisitor Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 05/31] NUMA: expand MAX_NODES from 64 to 128 Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 06/31] man: improve -numa doc Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 07/31] vl: redo -object parsing Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 08/31] qmp: allow object-add completion handler to get canonical path Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 09/31] qmp: improve error reporting for -object and object-add Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init Hu Tao
2014-05-07 14:50   ` Michael S. Tsirkin
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 11/31] numa: introduce memory_region_allocate_system_memory Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 12/31] add memdev backend infrastructure Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 13/31] numa: add -numa node, memdev= option Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 14/31] memory: reorganize file-based allocation Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 15/31] memory: move mem_path handling to memory_region_allocate_system_memory Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 16/31] memory: add error propagation to file-based RAM allocation Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 17/31] memory: move preallocation code out of exec.c Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 18/31] memory: move RAM_PREALLOC_MASK to exec.c, rename Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 19/31] hostmem: add file-based HostMemoryBackend Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 20/31] hostmem: separate allocation from UserCreatable complete method Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 21/31] hostmem: add merge and dump properties Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 22/31] hostmem: allow preallocation of any memory region Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 23/31] hostmem: add property to map memory with MAP_SHARED Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 24/31] configure: add Linux libnuma detection Hu Tao
2014-05-07 14:57   ` Michael S. Tsirkin [this message]
2014-05-08  8:34     ` Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy Hu Tao
2014-05-19 23:34   ` Eduardo Habkost
2014-06-06  3:37     ` Hu Tao
2014-06-06 16:15       ` Eduardo Habkost
2014-06-09  2:12         ` Hu Tao
2014-06-10 18:44           ` [Qemu-devel] MPOL_MF_STRICT & hugetlbfs (was Re: [PATCH v3.1 25/31] hostmem: add properties for NUMAS memory policy) Eduardo Habkost
2014-05-19 23:45   ` [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy Eduardo Habkost
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 26/31] Introduce signed range Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 27/31] qapi: make string input visitor parse int list Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 28/31] qapi: make string output " Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 29/31] qom: introduce object_property_get_enum and object_property_get_uint16List Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 30/31] qmp: add query-memdev Hu Tao
2014-05-06  9:27 ` [Qemu-devel] [PATCH v3.1 31/31] hmp: add info memdev Hu Tao
2014-05-08 14:51 ` [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements Paolo Bonzini
2014-05-09  2:57   ` Hu Tao
2014-05-09  8:29   ` Hu Tao
2014-05-09 17:54     ` Eduardo Habkost
2014-05-09 21:13       ` Paolo Bonzini
2014-05-13  2:28         ` Hu Tao
2014-05-13  2:12       ` Hu Tao
2014-05-09  6:24 ` [Qemu-devel] [PATCH] preallocate memory after NUMA policy configuration Marcelo Tosatti
2014-05-09  6:42   ` Hu Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507145713.GB16437@redhat.com \
    --to=mst@redhat.com \
    --cc=andre.przywara@amd.com \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).