qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Marcin Gibuła" <m.gibula@beyond.pl>
Cc: Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward
Date: Wed, 7 May 2014 20:23:27 -0300	[thread overview]
Message-ID: <20140507232327.GB25225@amt.cnet> (raw)
In-Reply-To: <53693DFB.3080108@beyond.pl>

On Tue, May 06, 2014 at 09:54:35PM +0200, Marcin Gibuła wrote:
> >Yes, and it isn't. Any ideas why it's not? This patch really just uses
> >the guest visible kvmclock time rather than the host view of it on
> >migration.
> >
> >There is definitely something very broken on the host's side since it
> >does return a smaller time than the guest exposed interface indicates.
> 
> Don't know if helps but here are example values from
> time_at_migration and s->clock from your patch.
> 
> Tested on 5 restores of saved VM that (used to) hang:
> 
>    s->clock      time_at_migration
> 157082235125698  157113284546655
> 157082235125698  157113298196976
> 157082235125698  157113284615117
> 157082235125698  157113284486601
> 157082235125698  157113284479740
> 
> Now, when I compare system time on guest with and without patch:
> 
> On unpatched qemu vm restores with date: Apr 18 06:56:36
> On patched qemu it says: Apr 18 06:57:06
> 
> -- 
> mg

Marcin,

Can you turn off the TSC clock on the host and attempt to reproduce the 
issue, without Alexander's patch? 

Just 

echo hpet > /sys/devices/system/clocksource/clocksource0/current_clocksource

(or any other clock except tsc if you don't have hpet).
TIA.

  reply	other threads:[~2014-05-07 23:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 13:51 [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward Alexander Graf
2014-05-05 17:46 ` Marcin Gibuła
2014-05-05 18:05   ` Alexander Graf
2014-05-05 18:26     ` Marcin Gibuła
2014-05-05 23:27       ` Marcelo Tosatti
2014-05-05 23:31         ` Marcelo Tosatti
2014-05-06  8:07           ` Marcin Gibuła
2014-05-06  7:11         ` Alexander Graf
2014-05-06  7:37         ` Marcin Gibuła
2014-05-05 23:23 ` Marcelo Tosatti
2014-05-05 23:31   ` Marcelo Tosatti
2014-05-06  7:18     ` Alexander Graf
2014-05-06 19:54       ` Marcin Gibuła
2014-05-07 23:23         ` Marcelo Tosatti [this message]
2014-05-07 23:21       ` Marcelo Tosatti
2014-05-07 23:29         ` Alexander Graf
2014-05-06  7:16   ` Alexander Graf
2014-05-07 10:04     ` Nick Thomas
2014-05-08  1:33 ` Marcelo Tosatti
2014-05-08  7:21   ` Alexander Graf
2014-05-09  2:28     ` Marcelo Tosatti
2014-05-09 11:53       ` Paolo Bonzini
2014-05-12 20:26         ` Alexander Graf
2014-05-14  7:26           ` Marcelo Tosatti
2014-05-14  6:47         ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507232327.GB25225@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=m.gibula@beyond.pl \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).