From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54423)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WiMSQ-00023g-59
	for qemu-devel@nongnu.org; Thu, 08 May 2014 07:25:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WiMSF-0002Hl-It
	for qemu-devel@nongnu.org; Thu, 08 May 2014 07:25:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58140)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WiMSF-0002H0-As
	for qemu-devel@nongnu.org; Thu, 08 May 2014 07:25:35 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s48BPYr8011935
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 8 May 2014 07:25:34 -0400
Date: Thu, 8 May 2014 13:25:32 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140508112532.GC10610@stefanha-thinkpad.redhat.com>
References: <1399458461-3997-1-git-send-email-stefanha@redhat.com>
	<1399458461-3997-18-git-send-email-stefanha@redhat.com>
	<536A0C7C.3060902@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <536A0C7C.3060902@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 17/25] block/raw-win32: implement
 .bdrv_detach/attach_aio_context()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Wed, May 07, 2014 at 12:35:40PM +0200, Paolo Bonzini wrote:
> >@@ -207,7 +217,6 @@ out_free_state:
> >
> > void win32_aio_cleanup(QEMUWin32AIOState *aio)
> > {
> >-    qemu_aio_set_event_notifier(&aio->e, NULL);
> 
> Perhaps it would be safer not to leave a dangling pointer in the
> AioContext, and detach manually here (or at least add an assertion).
> Can be done as a follow-up though.

I will add the assertion.