Re: [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)

[Fam Zheng <famz@redhat.com>]

On Thu, 05/08 15:02, Michael Tokarev wrote:
> $(INSTALL_PROG) is evaluated to libtool if using libtool, while
> $(INSTALL) is not.  Use $(INSTALL_PROG) so that libtool is used
> with target too when necessary.  This allows, for example, to
> link qemu with shared libcacard.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Alon Levy <alevy@redhat.com>
> Cc: qemu-trivial@nongnu.org

Reviewed-by: Fam Zheng <famz@redhat.com>

> --
> This is done on top of previous patch (using $(STRIP)), but it can
> be used by its own.
> ---
>  Makefile.target |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 8de8b12..3b75ade 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -194,7 +194,7 @@ endif
>  
>  install: all
>  ifneq ($(PROGS),)
> -	$(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> +	$(INSTALL_PROG) $(PROGS) "$(DESTDIR)$(bindir)"
>  ifneq ($(STRIP),)
>  	$(STRIP) $(PROGS:%="$(DESTDIR)$(bindir)/%")
>  endif
> -- 
> 1.7.10.4
>