* [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)
@ 2014-05-08 11:02 Michael Tokarev
2014-05-08 12:41 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2014-05-08 11:02 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, qemu-trivial, Michael Tokarev, Alon Levy,
Paolo Bonzini, Hollis Blanchard
$(INSTALL_PROG) is evaluated to libtool if using libtool, while
$(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used
with target too when necessary. This allows, for example, to
link qemu with shared libcacard.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alon Levy <alevy@redhat.com>
Cc: qemu-trivial@nongnu.org
--
This is done on top of previous patch (using $(STRIP)), but it can
be used by its own.
---
Makefile.target | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.target b/Makefile.target
index 8de8b12..3b75ade 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -194,7 +194,7 @@ endif
install: all
ifneq ($(PROGS),)
- $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
+ $(INSTALL_PROG) $(PROGS) "$(DESTDIR)$(bindir)"
ifneq ($(STRIP),)
$(STRIP) $(PROGS:%="$(DESTDIR)$(bindir)/%")
endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)
2014-05-08 11:02 [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL) Michael Tokarev
@ 2014-05-08 12:41 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2014-05-08 12:41 UTC (permalink / raw)
To: Michael Tokarev
Cc: qemu-trivial, Paolo Bonzini, Alon Levy, qemu-devel,
Hollis Blanchard
On Thu, 05/08 15:02, Michael Tokarev wrote:
> $(INSTALL_PROG) is evaluated to libtool if using libtool, while
> $(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used
> with target too when necessary. This allows, for example, to
> link qemu with shared libcacard.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Alon Levy <alevy@redhat.com>
> Cc: qemu-trivial@nongnu.org
Reviewed-by: Fam Zheng <famz@redhat.com>
> --
> This is done on top of previous patch (using $(STRIP)), but it can
> be used by its own.
> ---
> Makefile.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 8de8b12..3b75ade 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -194,7 +194,7 @@ endif
>
> install: all
> ifneq ($(PROGS),)
> - $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> + $(INSTALL_PROG) $(PROGS) "$(DESTDIR)$(bindir)"
> ifneq ($(STRIP),)
> $(STRIP) $(PROGS:%="$(DESTDIR)$(bindir)/%")
> endif
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-08 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 11:02 [Qemu-devel] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL) Michael Tokarev
2014-05-08 12:41 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).