* [Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)
@ 2014-05-08 11:06 Michael Tokarev
2014-05-08 12:41 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2014-05-08 11:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Michael Tokarev, Paolo Bonzini
We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but
uses correct permissions. Loadable objects (modules) are like
shared libraries, not like programs.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
---
Again, this is done on top of $(STRIP) patch, but can be done by
its own.
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 23ca444..12ea464 100644
--- a/Makefile
+++ b/Makefile
@@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),)
$(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)"
for s in $(modules-m:.mo=$(DSOSUF)); do \
t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \
- $(INSTALL_PROG) $$s "$$t"; \
+ $(INSTALL_LIB) $$s "$$t"; \
test -z "$(STRIP)" || $(STRIP) "$$t"; \
done
endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)
2014-05-08 11:06 [Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG) Michael Tokarev
@ 2014-05-08 12:41 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2014-05-08 12:41 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Paolo Bonzini, qemu-devel
On Thu, 05/08 15:06, Michael Tokarev wrote:
> We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but
> uses correct permissions. Loadable objects (modules) are like
> shared libraries, not like programs.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
> ---
> Again, this is done on top of $(STRIP) patch, but can be done by
> its own.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 23ca444..12ea464 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),)
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)"
> for s in $(modules-m:.mo=$(DSOSUF)); do \
> t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \
> - $(INSTALL_PROG) $$s "$$t"; \
> + $(INSTALL_LIB) $$s "$$t"; \
> test -z "$(STRIP)" || $(STRIP) "$$t"; \
> done
> endif
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-08 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 11:06 [Qemu-devel] [PATCH] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG) Michael Tokarev
2014-05-08 12:41 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).