qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Chris Friesen <chris.friesen@windriver.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] virtio-serial-pci very expensive during live migration
Date: Thu, 8 May 2014 18:32:31 +0530	[thread overview]
Message-ID: <20140508130231.GA24978@grmbl.mre> (raw)
In-Reply-To: <536AB2EE.6010504@windriver.com>

On (Wed) 07 May 2014 [16:25:50], Chris Friesen wrote:
> On 05/07/2014 12:39 AM, Paolo Bonzini wrote:
> >Il 06/05/2014 22:01, Chris Friesen ha scritto:
> >>
> >>It seems like the main problem is that we loop over all the queues,
> >>calling virtio_pci_set_host_notifier_internal() on each of them.  That
> >>in turn calls memory_region_add_eventfd(), which calls
> >>memory_region_transaction_commit(), which scans over all the address
> >>spaces, which seems to take the vast majority of the time.
> >
> >Yes, you can wrap the entire loop with memory_region_transaction_begin
> >and memory_region_transaction_commit.  Can you try that?
> 
> I tried the patch below.  Unfortunately it seems to cause qemu to crash.

This doesn't remove the memory_region_transaction_begin() and
_commit() from memory_region_add_eventfd(), which will still be
called.

Also, if you're not using all 32 ports, you can restrict the max
number of ports for a device using the
virtio-serial-pci.max_ports=uint32 property:

-device virtio-serial-pci,max_ports=2

		Amit

  reply	other threads:[~2014-05-08 13:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 20:01 [Qemu-devel] virtio-serial-pci very expensive during live migration Chris Friesen
2014-05-07  5:58 ` Markus Armbruster
2014-05-07  6:39 ` Paolo Bonzini
2014-05-07 22:25   ` Chris Friesen
2014-05-08 13:02     ` Amit Shah [this message]
2014-05-08 13:14       ` Paolo Bonzini
2014-05-08 13:30         ` Amit Shah
2014-05-08 13:36           ` Paolo Bonzini
2014-05-08 13:47             ` Amit Shah
2014-05-08 15:40               ` Chris Friesen
2014-05-09  0:53                 ` Chris Friesen
2014-05-09  8:19                   ` Paolo Bonzini
2014-06-19 15:19                     ` Chris Friesen
2014-06-19 15:31                       ` Paolo Bonzini
2014-05-08 14:31           ` Chris Friesen
2014-05-08 14:34             ` Paolo Bonzini
2014-05-08 15:57               ` Chris Friesen
2014-05-08 16:02                 ` Paolo Bonzini
2014-05-08 20:57                   ` Chris Friesen
2014-05-09  1:44               ` ChenLiang
2014-05-09  3:31                 ` Chris Friesen
2014-05-08  2:54   ` Gonglei (Arei)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140508130231.GA24978@grmbl.mre \
    --to=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=chris.friesen@windriver.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).