From: Marcelo Tosatti <mtosatti@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH] preallocate memory after NUMA policy configuration
Date: Fri, 9 May 2014 03:24:52 -0300 [thread overview]
Message-ID: <20140509062452.GA29352@amt.cnet> (raw)
In-Reply-To: <cover.1399365798.git.hutao@cn.fujitsu.com>
(note: applies on top of patchset of current thread)
Preallocate memory after the NUMA policy has been instantiated.
This is necessary to guarantee memory is allocated with
specified NUMA policy in place.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/backends/hostmem.c b/backends/hostmem.c
index d3f8476..3cfa8a0 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -293,9 +293,6 @@ host_memory_backend_memory_init(UserCreatable *uc, Error **errp)
if (!backend->dump) {
qemu_madvise(ptr, sz, QEMU_MADV_DONTDUMP);
}
- if (backend->prealloc) {
- os_mem_prealloc(memory_region_get_fd(&backend->mr), ptr, sz);
- }
#ifdef CONFIG_NUMA
unsigned long maxnode = find_last_bit(backend->host_nodes, MAX_NODES);
@@ -310,6 +307,9 @@ host_memory_backend_memory_init(UserCreatable *uc, Error **errp)
return;
}
#endif
+ if (backend->prealloc) {
+ os_mem_prealloc(memory_region_get_fd(&backend->mr), ptr, sz);
+ }
}
MemoryRegion *
next prev parent reply other threads:[~2014-05-09 6:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 9:27 [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 01/31] NUMA: move numa related code to new file numa.c Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 02/31] NUMA: check if the total numa memory size is equal to ram_size Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 03/31] NUMA: Add numa_info structure to contain numa nodes info Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 04/31] NUMA: convert -numa option to use OptsVisitor Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 05/31] NUMA: expand MAX_NODES from 64 to 128 Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 06/31] man: improve -numa doc Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 07/31] vl: redo -object parsing Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 08/31] qmp: allow object-add completion handler to get canonical path Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 09/31] qmp: improve error reporting for -object and object-add Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init Hu Tao
2014-05-07 14:50 ` Michael S. Tsirkin
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 11/31] numa: introduce memory_region_allocate_system_memory Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 12/31] add memdev backend infrastructure Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 13/31] numa: add -numa node, memdev= option Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 14/31] memory: reorganize file-based allocation Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 15/31] memory: move mem_path handling to memory_region_allocate_system_memory Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 16/31] memory: add error propagation to file-based RAM allocation Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 17/31] memory: move preallocation code out of exec.c Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 18/31] memory: move RAM_PREALLOC_MASK to exec.c, rename Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 19/31] hostmem: add file-based HostMemoryBackend Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 20/31] hostmem: separate allocation from UserCreatable complete method Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 21/31] hostmem: add merge and dump properties Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 22/31] hostmem: allow preallocation of any memory region Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 23/31] hostmem: add property to map memory with MAP_SHARED Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 24/31] configure: add Linux libnuma detection Hu Tao
2014-05-07 14:57 ` Michael S. Tsirkin
2014-05-08 8:34 ` Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy Hu Tao
2014-05-19 23:34 ` Eduardo Habkost
2014-06-06 3:37 ` Hu Tao
2014-06-06 16:15 ` Eduardo Habkost
2014-06-09 2:12 ` Hu Tao
2014-06-10 18:44 ` [Qemu-devel] MPOL_MF_STRICT & hugetlbfs (was Re: [PATCH v3.1 25/31] hostmem: add properties for NUMAS memory policy) Eduardo Habkost
2014-05-19 23:45 ` [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy Eduardo Habkost
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 26/31] Introduce signed range Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 27/31] qapi: make string input visitor parse int list Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 28/31] qapi: make string output " Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 29/31] qom: introduce object_property_get_enum and object_property_get_uint16List Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 30/31] qmp: add query-memdev Hu Tao
2014-05-06 9:27 ` [Qemu-devel] [PATCH v3.1 31/31] hmp: add info memdev Hu Tao
2014-05-08 14:51 ` [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements Paolo Bonzini
2014-05-09 2:57 ` Hu Tao
2014-05-09 8:29 ` Hu Tao
2014-05-09 17:54 ` Eduardo Habkost
2014-05-09 21:13 ` Paolo Bonzini
2014-05-13 2:28 ` Hu Tao
2014-05-13 2:12 ` Hu Tao
2014-05-09 6:24 ` Marcelo Tosatti [this message]
2014-05-09 6:42 ` [Qemu-devel] [PATCH] preallocate memory after NUMA policy configuration Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509062452.GA29352@amt.cnet \
--to=mtosatti@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).