From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WikNs-0007vF-Kk
	for qemu-devel@nongnu.org; Fri, 09 May 2014 08:58:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WikNo-0007iO-8Q
	for qemu-devel@nongnu.org; Fri, 09 May 2014 08:58:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WikNn-0007iJ-WE
	for qemu-devel@nongnu.org; Fri, 09 May 2014 08:58:36 -0400
Date: Fri, 9 May 2014 08:58:30 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140509085830.61539ebe@redhat.com>
In-Reply-To: <87oaz75cyy.fsf@blackfin.pond.sub.org>
References: <1399575182-9768-1-git-send-email-lcapitulino@redhat.com>
	<CAFEAcA9+9vxRWmgAZ7xXna5LLJtUb1KwGNDe6gM+5THFY8ZDcg@mail.gmail.com>
	<87oaz75cyy.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 00/38] QMP queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

On Fri, 09 May 2014 14:54:45 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Peter Maydell <peter.maydell@linaro.org> writes:
>=20
> > On 8 May 2014 19:52, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> >> The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8=
a19b3:
> >>
> >>   Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7'
> >> into staging (2014-05-08 10:57:25 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>
> >>   git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
> >>
> >> for you to fetch changes up to 4c56cbae6908cc597842e86e523886bb8ea8cfb=
8:
> >>
> >>   Revert "qapi: Clean up superfluous null check in
> >> qapi_dealloc_type_str()" (2014-05-08 14:20:26 -0400)
> >
> > Hi; this doesn't build for w32, I'm afraid:
> >
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c: In function
> > =E2=80=98qga_vss_fsfreeze=E2=80=99:
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error:
> > =E2=80=98err=E2=80=99 undeclared (first use in this function)
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error:
> > (Each undeclared identifier is reported only once
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error: for
> > each function it appears in.)
>=20
> My fault!  Apologies...
>=20
> The obvious fix needs to be squashed into "qga: Consistently name Error
> ** objects errp, and not err":

Yep. I'm testing this right now. A clear indication that neither you or
me are testing builds on w32/64.

We need a buildbot badly.