From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WihL9-00014c-Qo for qemu-devel@nongnu.org; Fri, 09 May 2014 05:43:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WihL4-0006AP-Ti for qemu-devel@nongnu.org; Fri, 09 May 2014 05:43:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WihL4-0006AI-M5 for qemu-devel@nongnu.org; Fri, 09 May 2014 05:43:34 -0400 Date: Fri, 9 May 2014 10:43:22 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140509094322.GB2423@work-vm> References: <536C0E5A.2030703@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536C0E5A.2030703@kamp.de> Subject: Re: [Qemu-devel] Question about RAM migration flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Paolo Bonzini , "qemu-devel@nongnu.org" , Stefan Hajnoczi , quintela@redhat.com * Peter Lieven (pl@kamp.de) wrote: > Hi, > > while working on ram migration and reading through the code I realized that > qemu does not stop loading a saved VM or rejecting an incoming migration > if there is a flag in the stream that it does not understand. An unknown flag > is simply ignored. > > In the block migration code there is a catch at the end complaining about > unknown flags, but in RAM migration there isn't. > > Is this on purpose or an error? I think it's in error; the code doesn't have much checking. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK