From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wikzu-0001AD-Nz for qemu-devel@nongnu.org; Fri, 09 May 2014 09:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wikzp-0004Ep-TG for qemu-devel@nongnu.org; Fri, 09 May 2014 09:37:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wikzp-0004Ei-Ll for qemu-devel@nongnu.org; Fri, 09 May 2014 09:37:53 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s49DbqqU002704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 9 May 2014 09:37:52 -0400 Date: Fri, 9 May 2014 21:38:03 +0800 From: Fam Zheng Message-ID: <20140509133803.GB7021@T430.nay.redhat.com> References: <1397098036-20605-1-git-send-email-famz@redhat.com> <87lhubje0e.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lhubje0e.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v18 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, jcody@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On Fri, 05/09 15:08, Markus Armbruster wrote: > No longer applies. It's been four weeks :( Hi Markus, Thanks for noticing this, I'll rebase and send another revision now. Fam > > Fam Zheng writes: > > > v18: Address reviewing comments from Jeff and Eric. Rebased to current master. > > Side by side diff from v17: http://bit.ly/1oO2Fvt > > > > [01/15] block: Add BlockOpType enum > > Add Jeff's reviewed-by. > > > > [02/15] block: Introduce op_blockers to BlockDriverState > > Add Jeff's reviewed-by. > > > > [03/15] block: Replace in_use with operation blocker > > Add Jeff's reviewed-by. > > > > [04/15] block: Move op_blocker check from block_job_create to its caller > > Add Jeff's reviewed-by. > > > > [05/15] block: Add bdrv_set_backing_hd() > > Don't unset bs->backing_file and bs->backing_format when > > backing_hd==NULL, because qcow2_close() will save these into image > > header. > > > > [08/15] block: Support dropping active in bdrv_drop_intermediate > > Swap parameters for bdrv_swap: > > bdrv_swap(active, base); -> bdrv_swap(base, active); > > Use bdrv_set_backing_hd(). > > > > [10/15] commit: Use bdrv_drop_intermediate > > New. (Jeff) > > > > [11/15] qmp: Add command 'blockdev-backup' > > Since 2.0 -> Since 2.1. (Eric) > > > > [13/15] block: Add blockdev-backup to transaction > > Comment "Since 2.1" for blockdev-backup. (Eric) > > > > [15/15] qemu-iotests: Image fleecing test case 089 > > Case number 083 -> 089. >