From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wis5H-0006lV-5J for qemu-devel@nongnu.org; Fri, 09 May 2014 17:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wis5B-0008SB-Ld for qemu-devel@nongnu.org; Fri, 09 May 2014 17:11:59 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:33379 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wis5B-0008QD-Fe for qemu-devel@nongnu.org; Fri, 09 May 2014 17:11:53 -0400 Date: Fri, 9 May 2014 23:12:24 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140509211223.GA31456@irqsave.net> References: <1394810322-13237-1-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394810322-13237-1-git-send-email-benoit.canet@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V3 0/3] Quorum maintainance operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com The Friday 14 Mar 2014 =E0 16:18:39 (+0100), Beno=EEt Canet wrote : Stefan, Kevin: Ping, I made this a dependency of Fam's nbd series to simplify his work on the job blockers. However Fam's series is a lot of work and takes time to merge. This patchset is the only thing I _must_ succeed to merge in time for 2.1. Would it be better to remove the dependency on the new blockers infrastru= cture to make it merge faster ? If not could one of the block maintainer have a look a this series so it = will be ready to apply once Fam's series get merged ? Best regards Beno=EEt > Hello, >=20 > This series for 2.1 add the missing maintainance feature for Quorum. >=20 > The first patch allows quorum to correct corrupted reads by rewriting t= hem. >=20 > The second add the drive-mirror-replace command to be used on a drive-m= irrored > device to replace a target bs by the mirror. >=20 > The series apply on top of Fam's NBD image feecing patches. >=20 > Best regards >=20 > Beno=EEt >=20 > in V3: >=20 > patch 2: > remove buggy assert [Max] > clarify qapi-schema.json comment [Max] >=20 > patch 3: > use sync=3Dfull [Max] > use iotest.notrun() [Max] >=20 > in V2: >=20 > Made all change suggested by Max >=20 > patch 1 > s/callback/callbacks/ > s/concurency/concurrency/ > s/;;/;/g > s/actived/enabled/ > Changed test order > Add Max reviewed by >=20 > patch 2 > s/file/SAN or NAS/g > add assert in bdrv_assign_node_name > The code must a target with the new mirror > as this could result in > s/check target/check that the target/ > Get the block driver state to be replaced > s/to replace/to be replaced/ > s/are/is/ > s/usefull/useful/g > avoid leaking s->new_node_name > s/switch/switches/ > s/replace/replaces/ >=20 > Beno=EEt Canet (3): > quorum: Add the rewrite-corrupted parameter to quorum. > block: Add drive-mirror-replace command to repair quorum files. > qemu-iotests: Add 088 new test for drive-mirror-replace. >=20 > block.c | 8 +- > block/mirror.c | 116 +++++++++++++++++++++- > block/quorum.c | 97 +++++++++++++++++-- > blockdev.c | 27 ++++++ > include/block/block.h | 3 + > include/block/block_int.h | 15 +++ > qapi-schema.json | 38 +++++++- > qmp-commands.hx | 5 + > tests/qemu-iotests/041 | 34 +------ > tests/qemu-iotests/081 | 15 ++- > tests/qemu-iotests/081.out | 10 ++ > tests/qemu-iotests/088 | 219 ++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/088.out | 5 + > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 33 +++++++ > trace-events | 1 + > 16 files changed, 580 insertions(+), 47 deletions(-) > create mode 100755 tests/qemu-iotests/088 > create mode 100644 tests/qemu-iotests/088.out >=20 > --=20 > 1.8.3.2 >=20