From: Hani Benhabiles <kroosec@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
afaerber@suse.de, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.
Date: Sun, 11 May 2014 13:06:28 +0100 [thread overview]
Message-ID: <20140511120628.GB4487@Inspiron-3521> (raw)
In-Reply-To: <536A1278.1070506@redhat.com>
On Wed, May 07, 2014 at 01:01:12PM +0200, Paolo Bonzini wrote:
> Il 05/05/2014 20:33, Luiz Capitulino ha scritto:
> >>+ data = object_property_get_qobject(obj, info->name, NULL);
> >>+ if (!data) {
> >>+ list = list->next;
> >>+ continue;
>
> You could use object_property_print and get rid of a relatively large amount
> of code.
Thanks for pointing that. But StringOutputVisitor doesn't have handlers for structs and
lists like QMP countrepart so the call segfaults when used against object
properties using that.
ie. Unless I am missing something, I should add those handlers to the string
visitor before being able to use object_property_print(), right ?
> Apart from this, the patch is definitely useful.
next prev parent reply other threads:[~2014-05-11 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398594570-14015-1-git-send-email-kroosec@gmail.com>
2014-05-05 18:33 ` [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand Luiz Capitulino
2014-05-07 11:01 ` Paolo Bonzini
2014-05-11 12:06 ` Hani Benhabiles [this message]
2014-05-07 15:39 ` Andreas Färber
2014-05-11 12:16 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140511120628.GB4487@Inspiron-3521 \
--to=kroosec@gmail.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).