From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjVD3-000669-58 for qemu-devel@nongnu.org; Sun, 11 May 2014 10:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjVCx-0007Gm-9A for qemu-devel@nongnu.org; Sun, 11 May 2014 10:58:37 -0400 Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:61955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjVCx-0007Gc-2d for qemu-devel@nongnu.org; Sun, 11 May 2014 10:58:31 -0400 Received: by mail-we0-f173.google.com with SMTP id u57so5783983wes.18 for ; Sun, 11 May 2014 07:58:30 -0700 (PDT) Date: Sun, 11 May 2014 15:58:27 +0100 From: Hani Benhabiles Message-ID: <20140511145827.GG4487@Inspiron-3521> References: <1399558877-4915-1-git-send-email-afaerber@suse.de> <1399558877-4915-5-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1399558877-4915-5-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH qom-next 4/4] qom: Implement qom-set HMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org, Luiz Capitulino On Thu, May 08, 2014 at 04:21:17PM +0200, Andreas Färber wrote: > Re-implemented based on qmp_qom_set() to facilitate argument parsing. > > Signed-off-by: Andreas Färber > --- > hmp-commands.hx | 13 +++++++++++++ > hmp.c | 18 ++++++++++++++++++ > hmp.h | 1 + > 3 files changed, 32 insertions(+) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index c0603e9..73145b7 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1704,6 +1704,19 @@ Print QOM property @var{property} of object at location @var{path} > ETEXI > > { > + .name = "qom-set", > + .args_type = "path:s,property:s,value:s", > + .params = "path property value", > + .help = "set QOM property", > + .mhandler.cmd = hmp_qom_set, > + }, > + > +STEXI > +@item qom-set @var{path} @var{property} @var{value} > +Set QOM property @var{property} of object at location @var{path} to value @var{value} > +ETEXI > + > + { > .name = "info", > .args_type = "item:s?", > .params = "[subcommand]", > diff --git a/hmp.c b/hmp.c > index d7d7a98..1cc2e60 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1715,3 +1715,21 @@ void hmp_qom_get(Monitor *mon, const QDict *qdict) > } > hmp_handle_error(mon, &err); > } > + > +void hmp_qom_set(Monitor *mon, const QDict *qdict) > +{ > + const char *path = qdict_get_str(qdict, "path"); > + const char *property = qdict_get_str(qdict, "property"); > + const char *value = qdict_get_str(qdict, "value"); > + Error *err = NULL; > + Object *obj; > + > + obj = object_resolve_path(path, NULL); Is there any consensus on whether to check for path ambiguity ? It seems to me that it would be more important to do so here than in qmp_qom_list() for example. Other than that, patch looks fine for me. > + if (obj == NULL) { > + error_set(&err, QERR_DEVICE_NOT_FOUND, path); > + hmp_handle_error(mon, &err); > + return; > + } > + object_property_parse(obj, value, property, &err); > + hmp_handle_error(mon, &err); > +} > diff --git a/hmp.h b/hmp.h > index 269d99e..6b7b1da 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -95,6 +95,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict); > void hmp_object_del(Monitor *mon, const QDict *qdict); > void hmp_qom_list(Monitor *mon, const QDict *qdict); > void hmp_qom_get(Monitor *mon, const QDict *qdict); > +void hmp_qom_set(Monitor *mon, const QDict *qdict); > void object_add_completion(ReadLineState *rs, int nb_args, const char *str); > void object_del_completion(ReadLineState *rs, int nb_args, const char *str); > void device_add_completion(ReadLineState *rs, int nb_args, const char *str); > -- > 1.8.4.5 > >