From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjpp1-0002uI-Ss for qemu-devel@nongnu.org; Mon, 12 May 2014 08:59:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjpov-0000uU-NO for qemu-devel@nongnu.org; Mon, 12 May 2014 08:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjpov-0000uC-FU for qemu-devel@nongnu.org; Mon, 12 May 2014 08:59:05 -0400 Date: Mon, 12 May 2014 08:58:59 -0400 From: Luiz Capitulino Message-ID: <20140512085859.22ccd580@redhat.com> In-Reply-To: <536D5B37.2010209@redhat.com> References: <1399575182-9768-1-git-send-email-lcapitulino@redhat.com> <1399575182-9768-9-git-send-email-lcapitulino@redhat.com> <536D5B37.2010209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 08/38] pci-assign: accept Error from monitor_handle_fd_param2() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, anthony@codemonkey.ws On Fri, 09 May 2014 16:48:23 -0600 Eric Blake wrote: > On 05/08/2014 12:52 PM, Luiz Capitulino wrote: > > From: Laszlo Ersek > > > > Propagate any errors in monitor fd handling up to get_real_device(), and > > report them there. We'll continue the propagation upwards when > > get_real_device() becomes a leaf itself (when none of its callees will > > report errors internally any longer when detecting and returning an > > error). > > > > Signed-off-by: Laszlo Ersek > > eviewed-by: Eric Blake > > If it's not too late, you may want to fix this R-b. It is too late.