From: Amos Kong <akong@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: djasa@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: return unspecified address according to protocol
Date: Mon, 12 May 2014 18:06:28 +0800 [thread overview]
Message-ID: <20140512100628.GE21308@amosk.info> (raw)
In-Reply-To: <1399887258.12413.6.camel@nilsson.home.kraxel.org>
On Mon, May 12, 2014 at 11:34:18AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > info->has_host = true;
> > - info->host = g_strdup(addr ? addr : "*");
> > + info->host = g_strdup(addr ? addr : (qemu_opt_get_bool(opts,
> > + "ipv6", 0)
> > + ? "::" : "0.0.0.0"));
>
> "ipv6" means "force ipv6". If the option is not present spice-server
> might still listen on ipv6, and qemu can't easily figure whenever that
> is the case or not.
OK. And management will not use this returned address, so it's
not a serious issue.
Thanks. NAK this patch.
> cheers,
> Gerd
>
>
--
Amos.
next prev parent reply other threads:[~2014-05-12 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 16:39 [Qemu-devel] [PATCH] spice: return unspecified address according to protocol Amos Kong
2014-05-12 9:34 ` Gerd Hoffmann
2014-05-12 10:06 ` Amos Kong [this message]
2014-05-12 12:38 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512100628.GE21308@amosk.info \
--to=akong@redhat.com \
--cc=djasa@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).