From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38916)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Wjn83-0005ST-DS
	for qemu-devel@nongnu.org; Mon, 12 May 2014 06:06:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Wjn7x-0003fm-9L
	for qemu-devel@nongnu.org; Mon, 12 May 2014 06:06:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Wjn7x-0003fg-27
	for qemu-devel@nongnu.org; Mon, 12 May 2014 06:06:33 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4CA6WWW022244
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 12 May 2014 06:06:32 -0400
Date: Mon, 12 May 2014 18:06:28 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20140512100628.GE21308@amosk.info>
References: <1399653553-5978-1-git-send-email-akong@redhat.com>
	<1399887258.12413.6.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1399887258.12413.6.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH] spice: return unspecified address
 according to protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: djasa@redhat.com, qemu-devel@nongnu.org

On Mon, May 12, 2014 at 11:34:18AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >      info->has_host = true;
> > -    info->host = g_strdup(addr ? addr : "*");
> > +    info->host = g_strdup(addr ? addr : (qemu_opt_get_bool(opts,
> > +                                                           "ipv6", 0)
> > +                                         ? "::" : "0.0.0.0"));
> 
> "ipv6" means "force ipv6".  If the option is not present spice-server
> might still listen on ipv6, and qemu can't easily figure whenever that
> is the case or not.

OK. And management will not use this returned address, so it's
not a serious issue.

Thanks. NAK this patch.
 
> cheers,
>   Gerd
> 
> 

-- 
			Amos.