From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjlIv-0004SD-Ty for qemu-devel@nongnu.org; Mon, 12 May 2014 04:09:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjlIm-0000FG-S2 for qemu-devel@nongnu.org; Mon, 12 May 2014 04:09:45 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:33011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjlIm-0000F4-I3 for qemu-devel@nongnu.org; Mon, 12 May 2014 04:09:36 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 May 2014 09:09:34 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CD00F2190056 for ; Mon, 12 May 2014 09:09:22 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4C89VN3328152 for ; Mon, 12 May 2014 08:09:31 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4C89Vj5030232 for ; Mon, 12 May 2014 02:09:31 -0600 Date: Mon, 12 May 2014 10:09:28 +0200 From: Cornelia Huck Message-ID: <20140512100928.2c749995.cornelia.huck@de.ibm.com> In-Reply-To: <53707FDB.4030208@de.ibm.com> References: <1399554218-8262-1-git-send-email-cornelia.huck@de.ibm.com> <1399554218-8262-2-git-send-email-cornelia.huck@de.ibm.com> <53707FDB.4030208@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/4] s390x: split flic into kvm and non-kvm parts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: qemu-devel@nongnu.org, agraf@suse.de On Mon, 12 May 2014 10:01:31 +0200 Christian Borntraeger wrote: > On 08/05/14 15:03, Cornelia Huck wrote: > > Introduce a common parent class for both cases, where kvm and non-kvm > > can hook up callbacks. This will be used by follow-on patches for > > adapter registration and mapping. > > > > We now always have a flic, regardless of whether we use kvm; the > > non-kvm implementation just doesn't do anything. > > > > Reviewed-by: Jens Freimann > > Signed-off-by: Cornelia Huck > > --- > > default-configs/s390x-softmmu.mak | 3 +- > > hw/intc/Makefile.objs | 1 + > > hw/intc/s390_flic.c | 318 ++++-------------------------------- > > hw/intc/s390_flic_kvm.c | 325 +++++++++++++++++++++++++++++++++++++ > > include/hw/s390x/s390_flic.h | 51 ++++-- > > Shouldnt we move this to include/hw/intc/ ? Current code is a bit undecided: Some interrupt controllers (like arm gic) have their headers in include/hw/intc/, some (like openpic and xics) in the architecture specific directories. Should we decide to collect all of those headers in include/hw/intc/, I vote for doing that in a general sweep. > > Otherwise: > Reviewed-by: Christian Borntraeger > > > > 5 files changed, 399 insertions(+), 299 deletions(-) > > create mode 100644 hw/intc/s390_flic_kvm.c