qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Mike Day <ncmike@ncultra.org>,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help.
Date: Mon, 12 May 2014 17:13:56 +0200	[thread overview]
Message-ID: <20140512151356.GC4371@noname.redhat.com> (raw)
In-Reply-To: <5370E340.5090401@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

Am 12.05.2014 um 17:05 hat Eric Blake geschrieben:
> On 05/12/2014 06:35 AM, Mike Day wrote:
> > For the create subcommand the backing file (-b) option is documented
> > on-line but not in the binary. Add it.
> > 
> > Signed-off-by: Mike Day <ncmike@ncultra.org>
> > ---
> >  qemu-img-cmds.hx | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
> > index d029609..7724709 100644
> > --- a/qemu-img-cmds.hx
> > +++ b/qemu-img-cmds.hx
> > @@ -16,9 +16,9 @@ STEXI
> >  ETEXI
> >  
> >  DEF("create", img_create,
> > -    "create [-q] [-f fmt] [-o options] filename [size]")
> > +    "create [-q] [-f fmt] [-b backing-file] [-o options] filename [size]")
> >  STEXI
> > -@item create [-q] [-f @var{fmt}] [-o @var{options}] @var{filename} [@var{size}]
> > +@item create [-q] [-f @var{fmt}] [-b @var{backing_file}] [-o @var{options}] @var{filename} [@var{size}]
> 
> There are two spellings for this:
> 
> -b file
> -o backing_file=file
> 
> is -o considered to be preferred over -b, as an explanation for why it
> is not documented?

Yes, it is. -b was documented before -o backing_file existed. Commit
8063d0fe removed it.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-05-12 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 12:35 [Qemu-devel] [PATCH] Add backing file option to qemu-img create help Mike Day
2014-05-12 15:05 ` Eric Blake
2014-05-12 15:13   ` Kevin Wolf [this message]
2014-05-12 15:20     ` Eric Blake
2014-05-12 15:36       ` Mike Day
2014-05-12 15:53         ` Eric Blake
2014-05-12 16:05           ` Mike Day
2014-05-12 16:32             ` Eric Blake
2014-05-12 16:36               ` Kevin Wolf
2014-05-12 17:02                 ` Eric Blake
2014-05-13  8:46                   ` Kevin Wolf
2014-05-12 17:10                 ` Mike Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512151356.GC4371@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ncmike@ncultra.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).