From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjtDi-0004oa-9G for qemu-devel@nongnu.org; Mon, 12 May 2014 12:37:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjtDc-0005TT-46 for qemu-devel@nongnu.org; Mon, 12 May 2014 12:36:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjtDb-0005Sz-T6 for qemu-devel@nongnu.org; Mon, 12 May 2014 12:36:48 -0400 Date: Mon, 12 May 2014 18:36:43 +0200 From: Kevin Wolf Message-ID: <20140512163643.GD4371@noname.redhat.com> References: <1399898143-28288-1-git-send-email-ncmike@ncultra.org> <5370E340.5090401@redhat.com> <20140512151356.GC4371@noname.redhat.com> <5370E6A0.3030406@redhat.com> <5370EE94.8090703@redhat.com> <5370F79A.4030508@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uZ3hkaAS1mZxFaxD" Content-Disposition: inline In-Reply-To: <5370F79A.4030508@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Mike Day , "qemu-devel@nongnu.org" , Stefan Hajnoczi --uZ3hkaAS1mZxFaxD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 12.05.2014 um 18:32 hat Eric Blake geschrieben: > On 05/12/2014 10:05 AM, Mike Day wrote: > > On Mon, May 12, 2014 at 11:53 AM, Eric Blake wrote: > >> Ah, but it is: > >> > >> $ qemu-img create -f qcow2 -o help > >> Supported options: > >> size Virtual disk size > >> compat Compatibility level (0.10 or 1.1) > >> backing_file File name of a base image > >> backing_fmt Image format of the base image > >> encryption Encrypt the image > >> cluster_size qcow2 cluster size > >> preallocation Preallocation mode (allowed values: off, metadata) > >> lazy_refcounts Postpone refcount updates > >> > >> and more importantly, it only appears in the help output of -f modes > >> that actually support a backing file. Contrast: > >> > >> $ qemu-img create -f raw -o help > >> Supported options: > >> size Virtual disk size > >=20 > > This is much more prominent in the top-level help: > >=20 > > rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F > > backing_fmt] filename >=20 > 'rebase' lacks -o; so it must continue to document -b. This thread was > started in context to the 'create' subcommand, not the 'rebase' > subcommand. (Arguably, we may need to add -o to rebase someday, but > that's not for this patch) What would qemu-img rebase do with -o? It is just for (safely) changing the backing file, not for updating options. There is qemu-img amend for that, and it does have an -o option. Kevin --uZ3hkaAS1mZxFaxD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcPibAAoJEH8JsnLIjy/We4YP/3VBjUYyAlakPtSntNKLXDVd UMCBy4gTtnzMK61SmL1XAPS7fWWwQCyjdPpwExjZWFcu1reGMS5Hp1bNkaSFy6me rMSiAt/vf1bSqz6smnMzUcSBsrIcbSX1FtCJyF6Lgu+KX6Q6T/DqzZuZlP3eiyjc yK6CkvJ6Mv9kum+7gv8PLfFy2Zu2YHP9qH/ZAoYIoL0sYpo5meUqxy+HlmPax3n/ MPqMZWJp9Bk23fp/ruXsJ7hNmMASfGwo409nK3Bq8o+MbdvGjLXmj9z5dbS/N6Ie IpoVNvPM/u5gZfwOjUwDAvkLT8Bxqgmn9nqkcag0xq4F7VV0l5MFVWJEMkr2RYaV VanJzYuWCnKmiS8HFiFzWpQv0qKuHPO1NL+eW26PEIP0S8nAfojcWF8wchJN/X7/ pXJTOl6rwVmfyNOU+jN8+Z7NGgG+mWvOd2Q3RavAg1SYRVMaJ0imDzMJNBOAObiZ kkSJg2Lna0GDSOjriabFBXSW0k3gnUuEF3sBvS+re4JUSyhObetG9Fyy8+IvRbtp lYdrrnc3CDEBsnQLmorkoofca1i65UB3mEzTZ16dFjsIc++fLeuuAKZSXaJcA824 8YY5Ivr0838vxUqsE8IdyP3E9MmJ7I9viDQFFPoC6jNJoP+wfvV2/7627btVIiP9 2yL5us7Lm+ewal8YLwL/ =bynO -----END PGP SIGNATURE----- --uZ3hkaAS1mZxFaxD--