From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8Mc-0006yS-GD for qemu-devel@nongnu.org; Tue, 13 May 2014 04:47:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk8MW-0006Et-Bb for qemu-devel@nongnu.org; Tue, 13 May 2014 04:47:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8MW-0006ED-3c for qemu-devel@nongnu.org; Tue, 13 May 2014 04:47:00 -0400 Date: Tue, 13 May 2014 10:46:56 +0200 From: Kevin Wolf Message-ID: <20140513084656.GC5267@noname.redhat.com> References: <1399898143-28288-1-git-send-email-ncmike@ncultra.org> <5370E340.5090401@redhat.com> <20140512151356.GC4371@noname.redhat.com> <5370E6A0.3030406@redhat.com> <5370EE94.8090703@redhat.com> <5370F79A.4030508@redhat.com> <20140512163643.GD4371@noname.redhat.com> <5370FE8C.90409@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline In-Reply-To: <5370FE8C.90409@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Add backing file option to qemu-img create help. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Mike Day , "qemu-devel@nongnu.org" , Stefan Hajnoczi --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 12.05.2014 um 19:02 hat Eric Blake geschrieben: > On 05/12/2014 10:36 AM, Kevin Wolf wrote: >=20 > >>> rebase [-q] [-f fmt] [-t cache] [-p] [-u] -b backing_file [-F > >>> backing_fmt] filename > >> > >> 'rebase' lacks -o; so it must continue to document -b. This thread was > >> started in context to the 'create' subcommand, not the 'rebase' > >> subcommand. (Arguably, we may need to add -o to rebase someday, but > >> that's not for this patch) > >=20 > > What would qemu-img rebase do with -o? It is just for (safely) changing > > the backing file, not for updating options. There is qemu-img amend for > > that, and it does have an -o option. >=20 > It's a consistency argument. Why can't we have: >=20 > rebase -o backing_file=3Dfile,backing_fmt=3Dfmt >=20 > similar to create, instead of having to treat rebase as the oddball > command that still takes separate options for two highly related items? But that's inconsistent with other -o options if you can't say: rebase -o lazy_refcounts=3Don rebase will always be the oddball because a backing file is not just an option for it, but it is the whole purpose of the command. Perhaps we shouldn't have used -b, but just a second non-option argument. But I don't think changing this now is worth it. Kevin --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcdwAAAoJEH8JsnLIjy/Wv/QQAMRbzJcMlZ4dx+pIftxeKeiv uWd84TG6SHmWrFKqHKP13C7PBz5i4JUhpi0GHEgkG1u7Hge8iZtKXBL8qkeVskIK kipUyMYsbgLWZuane+8KlmFzD48GVYHdTlzl6XAfWdPgKd7Q95dQy8oF2JHYpeXX V36rhL+avO2AW02aWWlDitefShVUKDVQT6Kzz+R0MZtDjfuN3ReSvUmZthv1Tk4M ETavBP5EmQ4y4X1y4y3IYyeN4hL5Kj4Nd6m8CDaeDBtXhOv81fcpUmRGjxT/2lj4 nHShMcwjUYdEeAUR981o2TpvK8zpSRZFGD77HF2XJAMGm6df4+rpWUonQtS28Bl7 C3c0Vdj+doALqeamueYJPLDxybZ2IJKt0sWSKQZoDLBsR205b72R5d+Z/MByWrdB vN1xmRh4CO/OwVEnkSTAejaO1fq0FfldWopLhiBZ5XsWu6QFDRvK+8sV8rZTZ/0h h6C9ypvMaMl1ZfVXfKcprUaKB1OeNu0swMCrCnMTuSZOo0IwDGxeLL53rUdD/UQU aey8ObzKiVlEZXmZCdBEFNei7LcLyI9jYfg1AjP4WMv97V4drGwaj9KuLB2fsuND kB3W6b9ziIeU4lBFxVSwBMldP6gAV+uSdozNiEQ0MQu9UPERsuixegqO3GY9UUFF QQhjLlzmT8v232eTnnKV =ilxA -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--